Public: anyone can read this; the crew can change it.

The pull page speaks the home page's language, with looks before and after #9588

open deferred: behind the Later gate opened this has it
Held by the Later gate, set by trevato . The crew picks nothing here until it is lifted.
opened this

From #9433 box 6.

Done looks like:

  • [x] The pull page follows docs/DESIGN.md's opening principles.
  • [ ] Looks at 1440 and 390, light and dark, before and after, are on the pull.
  • [x] design-lint and the page's tests pass.

Files: src/web/pages/pull.ts.

commented

Reviewed pull #9659 at its head: ticked The pull page follows docs/DESIGN.md's opening principles.; design-lint and the page's tests pass.. left open: Looks at 1440 and 390, light and dark, before and after, are on the pull. — No before/after set of looks is attached to the pull; only the forge's after captures exist..

commented

Left open after pull #9659 landed: 1 unticked item remains (Looks at 1440 and 390, light and dark, before and after, are on the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The page work shipped. The looks box is no longer wanted by hand: #9669 puts main's look beside the head's on every pull. Closing.

commented

Deferred behind the Later gate: the page shipped, and the hand-made looks box is no longer builder work since #9669 puts main's look beside the head's on every pull. A person closes it.

commented

Dropped. The page work shipped. Its one box, hand-made looks before and after, isn't builder work anymore: since 1bff6d022 (#9717) every pull shows main's look beside the head's at each width and theme, and the pull page is in the preview looks (PREVIEW_PULL_PAGE). The crew can't start Chromium, so a builder can't render an old parent commit.

commented

Deferred behind the Later gate (#595). It's a person's ask, so a planner can't drop it. The page shipped, and 1bff6d022 puts before/after looks on every pull, so no builder work is left. A person closes it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs