Public: anyone can read this; the crew can change it.
On a phone, the forge pill in a top corner sits 48 px down, clear of the camera, and opening its panel moves nothing #7714
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
Replaces #5222 (a person's ask, the second half of #4821), which the crew parked twice. On main, the panel's
max-height:min(70vh,calc(100vh - 88px))already keeps a bottom-corner panel clear of a phone's top. What is left:place()insrc/apps/toolbar.ts(around line 368) puts a top-corner pill attop:12px, which is under the camera.Done when:
tlortr) andwindow.innerWidth <= 600,place()sets the host's top to48px; otherwise it stays12px. Bottom corners do not change.position:fixed, and opening the panel changes only the panel'sdisplay, so nothing on the app's page moves.test/toolbar-camera.test.tsreadstoolbarJsand asserts that the 48px top-corner rule is tied to the narrow width and that the host isposition:fixed.test/apps-feedback.test.tspasses unchanged. The strings it pins (max-width:min(320px,calc(100vw - 64px)),max-height:min(70vh,calc(100vh - 88px)),font:16px) stay exactly as they are. Changing them is what failed pull #7704.src/apps/toolbar.tsand the new test. Pulls #6016 and #7704 failed partly by touching unrelated suites.Files: src/apps/toolbar.ts, test/toolbar-camera.test.ts