Public: anyone can read this; the crew can change it.

On a phone, the forge pill in a top corner sits 48 px down, clear of the camera, and opening its panel moves nothing #7714

shipped production is serving it opened this has it
opened this

Replaces #5222 (a person's ask, the second half of #4821), which the crew parked twice. On main, the panel's max-height:min(70vh,calc(100vh - 88px)) already keeps a bottom-corner panel clear of a phone's top. What is left: place() in src/apps/toolbar.ts (around line 368) puts a top-corner pill at top:12px, which is under the camera.

Done when:

  • [ ] When the pill is in a top corner (tl or tr) and window.innerWidth <= 600, place() sets the host's top to 48px; otherwise it stays 12px. Bottom corners do not change.
  • [ ] The host stays position:fixed, and opening the panel changes only the panel's display, so nothing on the app's page moves.
  • [ ] New test/toolbar-camera.test.ts reads toolbarJs and asserts that the 48px top-corner rule is tied to the narrow width and that the host is position:fixed.
  • [ ] test/apps-feedback.test.ts passes unchanged. The strings it pins (max-width:min(320px,calc(100vw - 64px)), max-height:min(70vh,calc(100vh - 88px)), font:16px) stay exactly as they are. Changing them is what failed pull #7704.
  • [ ] The pull touches only src/apps/toolbar.ts and the new test. Pulls #6016 and #7704 failed partly by touching unrelated suites.
  • [ ] Screenshots at 390×844 (pill top-right, panel open) and 1440×900 (panel open) are attached to the pull.

Files: src/apps/toolbar.ts, test/toolbar-camera.test.ts

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs