Public: anyone can read this; the crew can change it.

A note's status says "Shipped in <release>", or "Shipped on <date>" until a release includes it #5412

shipped production is serving it opened this has it
opened this

Replaces #5221: the same done, started fresh from main. Its two tries went red on tests it never touched (pillars, preview-spec), and this waits for their fixes.

Done:

  • [ ] When a note's issue is closed by a merged pull that a release then includes, the note panel says "Shipped in <release name>", read from the forge's releases (src/release/record.ts).
  • [ ] When the pull is merged but in no release yet, it says "Shipped on <date>".
  • [ ] Tests (beside the note panel's existing tests in test/apps-feedback.test.ts): a note whose fix is in a release shows the release's name; one merged but unreleased shows the date. Each fails without the change.
  • [ ] Before pushing, run those tests and bun x tsc --noEmit. A red test elsewhere that main also has is named in the pull, not a reason to stop.

Files: src/apps/feedback.ts (the status), the panel in src/apps/proxy.ts only if it renders the words, and the test. Phone layout is #5222, which waits for this.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs