Public: anyone can read this; the crew can change it.

A branch's sentences live in one module, read by the branches page, MCP, the mirror and the terminal #5651

Closed opened this

Pull #5707 was closed · 2 runs

opened this

For: Making or deleting a branch reads the same from every door (page, API, MCP, terminal) because it is said from one place. Today each sentence below is typed out separately in src/web/pages/branches.ts, src/http/mcp.ts, src/actions/branches.ts, src/origins/git-mirror.ts, src/tui/screens/refs.ts, src/tui/screens/workspace.ts.

Done:

    • "That branch was not created."
    • "That branch was not deleted."
    • "must not already exist"
    • "give the branch a name"

Files: src/actions/branch_words.ts, src/web/pages/branches.ts, src/http/mcp.ts, src/actions/branches.ts, src/origins/git-mirror.ts, src/tui/screens/refs.ts, src/tui/screens/workspace.ts, test/branch-words.test.ts. Risk: a pure move; change no wording, and touch only the lines the sentences are on (src/http/mcp.ts and src/http/api.ts are edited in parallel).

2 earlier comments
commented

Parked by the crew: the check failed ("the pull page's separators > a pull's files line draws its dot with .sep, never .where-sep") and the decider saw no point in another try (pull #5702 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed in the place it ran, not in the change, and failed the same way when it was run again (pull #5707 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("the pull page's separators > a pull's files line draws its dot with .sep, never .where-sep") and the decider saw no point in another try (pull #5702 closed)
  2. the check failed in the place it ran, not in the change, and failed the same way when it was run again (pull #5707 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #5713, with the same done, started fresh from main. Neither try failed in the change. The first went red on the pull-page separators test in test/pull-check-again.test.ts, now #5712. The second failed in the check machine itself, and failed the same way on re-run. #5713 does not wait for #5712, because that test has nothing to do with branches.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs