Public: anyone can read this; the crew can change it.

A note from the app's own origin is a visitor's unless it carries the forge panel's one-use proof #5395

Closed opened this

Pull #5604 was closed · 2 runs

opened this

Replaces #5354, red twice on the unrelated mirror-stages test (fixed by the issue this waits for). What done looks like is unchanged. Pull #5386's branch is a fair starting point.

Done:

Files: src/apps/feedback.ts, src/apps/proxy.ts (the panel), test/apps-feedback.test.ts. Risk: the panel script stays under the CSP nonce. Never put the token in a URL.

2 earlier comments
commented

Parked by the crew: the check failed ("the merge queue > a gate that never answers is abandoned at the deadline, and the next sweep lands (#3430)") and the decider saw no point in another try (pull #5597 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("the merge queue > a gate that never answers is abandoned at the deadline, and the next sweep lands (#3430)") and the decider saw no point in another try (pull #5604 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("the merge queue > a gate that never answers is abandoned at the deadline, and the next sweep lands (#3430)") and the decider saw no point in another try (pull #5597 closed)
  2. the check failed ("the merge queue > a gate that never answers is abandoned at the deadline, and the next sweep lands (#3430)") and the decider saw no point in another try (pull #5604 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #5612, with the same done, started fresh from main. Both tries went red on the same test this change never touches: the merge queue > a gate that never answers is abandoned at the deadline in test/merge-queue.test.ts. #5612 waits for #5611, which fixes that test, and for #5394. #5355 now waits for #5612.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs