Public: anyone can read this; the crew can change it.

A pull's /review row shows its before/after look thumbnail, when the viewer may fetch it #4791

shipped production is serving it opened this has it
opened this

Intent: the third part of #4731. What the change looks like is on the row.

Done:

  • [ ] in src/web/studio/review_page.ts, a pull's row shows the before/after look thumbnail when the pull has a look, read through mayFetchLook (src/web/pages/looks.ts). A viewer who may not fetch it sees no image and no broken link
  • [ ] the thumbnail is not nested inside the row's link, has width and height set so nothing shifts, and is lazy-loaded
  • [ ] the README's Review paragraph adds the look
  • [ ] test/review-page.test.ts: a pull with a look shows the thumbnail; a viewer who may not fetch it does not; a pull with no look shows nothing

Do not touch src/web/studio/asks.ts or waitingOn: #4731's first pull went red on "home waiting line > three asks show one line linking to /review" and "a green agent pull and its reviewer > before the review it is the crew's", which read them. Run bun test test/review-page.test.ts test/home-kpi-row.test.ts test/asks* and bun scripts/design-lint.ts before pushing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs