Public: anyone can read this; the crew can change it.
Act from /review: Merge, Close, Request changes, Reply, by button or key, then the next item #3258
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
Part 3 of #3247.
Done looks like:
- Merge, through the existing landing gate, never around it - Close - Request changes, with a text box - Reply, with a text box
Each is a plain form POST that works without script, with the same-origin check and CSRF the other mutations use.
/review#<next ask>, and the acted item is gone.bun test test/design-lint.test.tspasses before the push.test/review-act.test.tscovers each action on a seeded item: it takes effect (merged through the gate, closed, review recorded, comment posted) and the redirect points at the next item. Merging a pull whose check is red is refused with the gate's sentence.Files:
src/web/studio/review_page.ts,src/http/server.ts,test/review-act.test.ts. Risks: Merge must reuse the landing gate's code path, so a person's merge here is held to the same rules as anywhere.