Public: anyone can read this; the crew can change it.
A stale green holds back the inbox's look ask and disables the merge button (after #1179) #2028
commented
Parked by the crew: the check failed ("apps: identity, and a deploy that never answers > a deploy that never answers leaves servingAt null") and the decider saw no point in another try (pull #2274 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.
Sign in to join this conversation.
Part of #1133 (P0 Trust). Replaces #2014, which was parked twice because the stale-green model it builds on (#1179) is not on
mainyet. This waits for #1179 and then closes the two gaps #1179 does not name.Intent. When a pull's green was checked against an older base, the inbox does not ask for a look, and the page's merge button is not offered.
Done looks like.
src/web/studio/asks.ts, thelookandreviewasks treat a stale green (#1179'scheckStale) as a check still running: there is no ask until the re-check passes.src/web/pages/pull.tsmergeBox, withrequireChecksset, a stale green reads "Waiting on checks", with the reason "checked against an older <base>; checking again", and Merge pull request is disabled. The page never offers a merge thatmergePullrefuses.Files.
src/web/studio/asks.ts,src/web/pages/pull.ts, the stale-check test #1179 adds.Risks. Computing the base tip for every pull on the inbox could be slow. Resolve it only when the latest check is
okand has abaseOid.Fits. Mason.
Before pushing.
bun x tsc --noEmitand the test files named here.