Public: anyone can read this; the crew can change it.
A pull's green is the merge's green: checks run on the merge with its base, a conflict is said first, and a stale green never reads as ready #1133
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
Today the owner's inbox showed trevato/cs#207 as a green pull on him, and the owner approved it on that green. It had conflicted with main for weeks (22 commits moved under it) and its reviewer had asked for changes. The check was honest about what it tested — the head commit, alone — and wrong about what the person reads it as: that the change is ready to land.
Done looks like:
mergeable,conflictson the pull JSON). A conflicted pull is never shown with a green mark anywhere.GET /api/v1/repos/:owner/:name/pulls/:numbercarriesmergeable,conflicts,checkedAgainstandapprovedAt.Files I expect:
src/checks/service.ts(merge-ref check),src/core/pulls.ts(mergeStatus),src/web/pages/pull.ts(checksLine),src/web/pages/site.ts(inbox rows),src/http/api.ts.