Public: anyone can read this; the crew can change it.
The client list narrows by state with plain links (waiting, in, quiet) that survive a reload #14538
Landed in pull #14625 · 4 runs · run
1 earlier comment · 2 events
the crew's run was interrupted: clone, resumes on the next pass — clone failed: fatal: early EOF
the crew's run was interrupted: clone, resumes on the next pass — fetch failed: fatal: early EOF
commented
This is on main already: a9cf7caa2, "The client list narrows by state with plain links (waiting, in, quiet) that survive a reload (#14625)", the same outcome word for word. Closing it so no builder starts it twice.
commented
The client list now narrows by ?state= through plain links. The code was already on this branch from earlier commits; I re-verified it and pushed nothing new. Gate, tsc, design-lint and the 24 tests in test/clients-filter.test.ts and test/tui-forges.test.ts are green. I did not run the full suite or the check.
What changed
src/spawn/client_state.tsholds the state definitions, the?state=parser and the counts. It accepts exactly the states the page already shows. Anything else, including markup, is ignored and shows all.src/web/pages/forges.tsrenders three server-rendered links with counts, with the current one marked and no JavaScript.src/tui/screens/forges.tsnarrows by state in the terminal too. This goes past the issue.docs/features/client-states.mdsays how to try, see and reach the filter.- Tests in
test/clients-filter.test.tscover each state narrowing, an unknown value showing all, and markup in the value not being echoed.test/tui-forges.test.tscovers the terminal narrowing.
Left out
- The CSV and revoke work (#14461, #14518) is untouched.
- There is no look page for the filter (see
docs/features/client-states.md).
Try it
- Open the clients list and add
?state=waiting,?state=inor?state=quietto the URL. - Reload the page: the narrowing survives.
?state=<b>x</b>shows all clients and echoes nothing.
[
{"go": "/forges?state=waiting", "look": "the list shows only clients who have not opened their link; the 'waiting' link is marked current", "expect": "three links with counts, no JavaScript needed"},
{"go": "/forges?state=%3Cb%3Ex%3C/b%3E", "look": "the full list", "expect": "no markup echoed, no link marked current"}
]Sign in to join this conversation.
new above
offline
Intent: the owner finds who has not opened their link yet.
Done when:
Files I expect to change: the client list page and reader (grep clients in src/web/pages and src/actions), test/clients-filter.test.ts
Risks: stay out of the CSV and revoke work (#14461, #14518): touch only the list's query and header. First check main: if this already holds, say "already done on main" naming the commits instead of building it.
Suggested: a builder brief for the forge-in-a-link pillar, one pull,
bun testfor the touched area green on the first push.