Public: anyone can read this; the crew can change it.

Dark mode's before/after pictures at 390 and 1280 px, light and dark, are on its pull #13069

Closed opened this has it

Landed in pull #13082 · run

opened this

Dark mode's before/after pictures at 390 and 1280 px, light and dark, are on its pull.

Done:

Files I expect to change: no source change; looks only Risks: none; if a page fails 4.5:1 in a picture, file the defect rather than patching here Suggested brief: a builder (Sonnet-sized, one pull). Includes a test that fails without the change.

commented

Reviewed pull #13082 at its head: ticked Replaces the one open box left on #13008, whose pull shipped. left open: Four pictures (390 and 1280 px, light and dark) of /, /apps and /settings are attached with the pull's looks — The looks on this head are phone and desktop only, with no dark variant, and /settings is pictured as /settings/crew.; Each pair names the token pair it shows from the 4.5:1 table — The doc lists the token pairs but deliberately does not say which picture shows which, and there are no dark pictures to name..

commented

Left open after pull #13082 landed: 2 unticked items remain (Four pictures (390 and 1280 px, light and dark) of /, /apps and /settings are attached with the pull's looks; Each pair names the token pair it shows from the 4.5:1 table). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs