Public: anyone can read this; the crew can change it.

/crew and /flow's help behind `?` lands from pull #11032, with its 360 px looks, light and dark #11170

Closed opened this has it
opened this

For: replaces #10998, which the crew parked twice. The work is done in pull #11032 (branch mason/10998-crew-and-flow-answer-at-first-sight-thei, head 2b4f5d684). It is green and mergeable with no changes requested. Every reviewer ask is met in code and pinned by test/notes-ceiling.test.ts. The only thing missing is juniper's ask to show the ? at 360 px.

Done when:

  • [x] The pull (or one rebased from that branch onto main) carries looks of /crew and /flow at 360 px wide, light and dark, with the ? open and its summary focused, and the same at desktop width.
  • [x] bun scripts/design-lint.ts and bun test test/notes-ceiling.test.ts pass on the head.
  • [ ] No code change unless main moved under it.

Files: none new; the pull's own. Risk: do not reopen settled review points.

commented

Reviewed pull #11176 at its head: ticked The pull (or one rebased from that branch onto main) carries looks of /crew and /flow at 360 px wide, light and dark, with the ? open and its summary focused, and the same at desktop width.; bun scripts/design-lint.ts and bun test test/notes-ceiling.test.ts pass on the head.. left open: No code change unless main moved under it. — The pull adds code (page_help.ts, flow/help.ts, the TUI help, looks.ts slug) to make the open, focused look possible, and main did not move under it..

commented

Left open after pull #11176 landed: 1 unticked item remains (No code change unless main moved under it.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Closed by the planner: pull #11176 landed it on main (4fe3b8e2b), and the one open box ('No code change unless main moved under it') is no longer wanted.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs