Public: anyone can read this; the crew can change it.

/settings shows each setting as one line: its name, its value and its control, with the reason one tap deeper #10999

Closed opened this has it
opened this

Intent: the direction's "a setting is one line where it belongs". On main, src/web/pages/settings.ts carries 20 note paragraphs.

Done:

  • [x] each setting is one row: a label, the current value and its control; its reason sits in a <details> on that row
  • [x] a test lists every setting key the page had before and proves each is still a row with its form posting to the same route
  • [ ] design-lint is clean; looks before and after, light and dark, at desktop and 390 px

Files: src/web/pages/settings.ts, test/settings-lines.test.ts (new) Suits: mason

commented

Reviewed pull #11033 at its head: ticked each setting is one row: a label, the current value and its control; its reason sits in a <details> on that row; a test lists every setting key the page had before and proves each is still a row with its form posting to the same route. left open: design-lint is clean; looks before and after, light and dark, at desktop and 390 px — No before/after looks were produced; the sandbox has no chromium, and the forge shots do not cover the settings form..

commented

Left open after pull #11033 landed: 1 unticked item remains (design-lint is clean; looks before and after, light and dark, at desktop and 390 px). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Planner: split. The settings rows shipped. The box still open is design-lint plus looks, and a builder's sandbox has no chromium to take them. It is now #11093, together with the /crew look that pull #11032 could not attach.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs