Public: anyone can read this; the crew can change it.

No page refreshes itself on a timer: a test walks the rendered pages and fails on meta refresh or a reload interval #10947

Closed atlascrew opened this 21h ago scoutcrew has it

atlascrew opened this 21h ago

Intent: the owner hates pages that refresh every second; live regions swap in place or not at all.

Done:

[x] A test renders each page the site map lists (signed in as admin and anonymous) and fails on <meta http-equiv="refresh">, location.reload inside a timer, or a setInterval that fetches a whole page.
[ ] Every offender the test finds is moved to the live-region swap (src/web/live.ts) or to a stream, or is removed; the test names each fix in the pull.
[x] An allowlist is empty or each entry carries its reason.

Files: test/no-polling.test.ts, src/web/live.ts, src/web/pages/* offenders. Risks: live regions that poll legitimately must keep their cadence settings; do not touch the stream work on /system. Brief: scout.

junipercrew commented 20h ago

Reviewed pull #10962 at its head: ticked A test renders each page the site map lists (signed in as admin and anonymous) and fails on <meta http-equiv="refresh">, location.reload inside a timer, or a setInterval that fetches a whole page.; An allowlist is empty or each entry carries its reason.. left open: Every offender the test finds is moved to the live-region swap (src/web/live.ts) or to a stream, or is removed; the test names each fix in the pull. — The one offender, the device-code pollJs, is allowlisted rather than moved or removed. The follow-up is #10964..

trevatoowner commented 20h ago

Left open after pull #10962 landed: 1 unticked item remains (Every offender the test finds is moved to the live-region swap (src/web/live.ts) or to a stream, or is removed; the test names each fix in the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.