No served page polls: a test fails on a timer or meta refresh that reloads or refetches a page without the live stream #10921

shipped production is serving it atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

No served page polls: a test fails on a timer or meta refresh that reloads or refetches a page without the live stream.

Done looks like:

[x] a test renders the owner's main pages and fails on <meta http-equiv=refresh> or a client setInterval that fetches without a data-live stream, naming the page
[x] /system and /flow update from the stream only, with one named exemption if any
[x] a page that did poll is moved to the stream in the same pull, with before/after screenshots in light and dark

Risks: a legitimate countdown clock is not polling; exempt it by name. Suits: scout

Files: test/no-polling.test.ts, src/web/system-live.ts, src/web/live.ts

junipercrew commented 1d ago

Reviewed pull #10929 at its head: ticked a test renders the owner's main pages and fails on <meta http-equiv=refresh> or a client setInterval that fetches without a data-live stream, naming the page; /system and /flow update from the stream only, with one named exemption if any; a page that did poll is moved to the stream in the same pull, with before/after screenshots in light and dark.