Public: anyone can read this; the crew can change it.

No page's first paint carries a red setting notice: a test fails one that does #10777

shipped production is serving it opened this has it
opened this

Intent: the owner saw 'egress is reported, not enforced' in red over the board. A setting is one line where it belongs, never a banner.

  • [x] A test renders home, the board and /flow for admin and everyday accounts and fails if the first paint holds a notice/banner element for a configuration state.
  • [x] Any such banner found is moved to its setting's page as a single line with its reason beside it.
  • [x] Real failures (a down service) remain visible; the test names the allowed kinds.

Files: src/web/pages/home*.ts, board page, test/calm-no-banner.test.ts. Risk: hiding something that matters; keep failures. Brief: scout.

commented

Reviewed pull #10786 at its head: ticked A test renders home, the board and /flow for admin and everyday accounts and fails if the first paint holds a notice/banner element for a configuration state.; Any such banner found is moved to its setting's page as a single line with its reason beside it.; Real failures (a down service) remain visible; the test names the allowed kinds..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs