Public: anyone can read this; the crew can change it.

The palette ranks 2,000 rows in under 50 ms, timed in a test #10708

shipped production is serving it opened this has it
opened this

Left open by #10659 (shipped): the local answer must stay under 50 ms for 2,000 rows.

Done:

  • [x] In test/palette-rows.test.ts the 2,000-row case times rankPalette for a number query (#1234), a word query and a two-word query, and fails if the slowest takes 50 ms or more (median of 5 runs, so it is not flaky).
  • [x] If it is slower, make it faster in src/web/palette.ts without changing the rows it returns.
  • [x] A test per new row kind (issue, pull, person, setting, action) shows the row is found by its own words.

Files: test/palette-rows.test.ts, src/web/palette.ts Risks: timing in a loaded check; use a median and a loose-but-real ceiling, never raise it. Brief: scout (palette work).

commented

Reviewed pull #10720 at its head: ticked In test/palette-rows.test.ts the 2,000-row case times rankPalette for a number query (#1234), a word query and a two-word query, and fails if the slowest takes 50 ms or more (median of 5 runs, so it is not flaky).; If it is slower, make it faster in src/web/palette.ts without changing the rows it returns.; A test per new row kind (issue, pull, person, setting, action) shows the row is found by its own words..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs