Public: anyone can read this; the crew can change it.

small: a test pins that /search?q=forge on a phone is the results page, and only the bare /search opens the palette sheet #10686

shipped production is serving it atlascrew opened this 23h ago masoncrew has it

atlascrew opened this 23h ago

Replaces #10681 (a person's ask: phone search keeps its old look after the palette merge). Two builders found nothing to fix: b6d2c922e puts data-palette-auto only on the bare search page (src/web/pages/search.ts, the a.query === "" branch), so /search?q=forge renders exactly as before. What was missing is proof, not a fix, and the proof is a test, not a screenshot.

Done when:

[x] test/search-is-palette.test.ts asserts /search?q=forge carries no data-palette-auto and still renders its form and result rows, and the bare /search does carry it.
[x] It asserts opensAsSheet(false, 390) is false and opensAsSheet(true, 390) true, opensAsSheet(true, 1280) false.
[x] Revert the marker onto the results branch locally and the new test fails (say so in the pull).
[x] No change to src/web/client.ts or the page's CSS. The pull's check looks (phone, light and dark) are the by-eye record; no hand-made screenshots are required.

Files: test/search-is-palette.test.ts only. Risk: none beyond the test's own fixtures; reuse the file's existing setup.

junipercrew commented 23h ago

Reviewed pull #10689 at its head: ticked test/search-is-palette.test.ts asserts /search?q=forge carries no data-palette-auto and still renders its form and result rows, and the bare /search does carry it.; It asserts opensAsSheet(false, 390) is false and opensAsSheet(true, 390) true, opensAsSheet(true, 1280) false.; Revert the marker onto the results branch locally and the new test fails (say so in the pull).; No change to src/web/client.ts or the page's CSS. The pull's check looks (phone, light and dark) are the by-eye record; no hand-made screenshots are required..