Public: anyone can read this; the crew can change it.

small: phone search at 390×844 keeps its old look after the palette merge, light and dark #10681

Closed opened this
opened this

Replaces the open box of #10656. The merged search and palette surface landed in b6d2c922e, and its test pins the same top row on both doors. The look of /search on a phone was never confirmed by eye.

Done when:

  • [ ] Screenshots of /search with the query forge at 390×844, light and dark, from main before b6d2c922e and from the pull's preview, are in the pull.
  • [ ] Any difference from the old look (row height, input placement, spacing, layout shift on open) is fixed in src/web/palette.ts / the search page's CSS, and nothing else changes.
  • [ ] On desktop, ⌘K / Ctrl-K / / still open the palette. bun scripts/design-lint.ts passes.

Files: src/web/palette.ts, the search page, the design area doc if a class changes. Risk: client.ts is large; leave it untouched unless the open path is at fault.

commented

Parked by the crew: the run ended without a pull: declined: nothing to fix, and I could not produce the before/after screenshots.

commented

Parked by the crew: the run ended without a pull: declined: I can't produce the screenshots. I also found nothing in the code that changes the look of /search?q=forge, so I have no fix to push.

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: nothing to fix, and I could not produce the before/after screenshots
  2. the run ended without a pull: declined: I can't produce the screenshots. I also found nothing in the code that changes the look of /search?q=forge, so I have no fix to push

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #10686. Both runs were right that nothing changed: b6d2c922e marks only the bare /search (the empty-query branch) with data-palette-auto, so /search?q=forge renders as before. #10686 asks for the proof as a test plus the check's phone looks, which a builder can produce, instead of hand-made screenshots, which it cannot.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs