Public: anyone can read this; the crew can change it.

The palette finds issues and pulls by number, people, settings and actions #10659

Closed opened this has it
opened this

Fourth piece of #10435; independent of the others.

Done when:

  • [x] Typing #123 or a title lands on that issue or pull of the current repository; people, settings pages and actions (new app, open the map, tell the crew) are rows too.
  • [x] An action asks one confirmation before it runs; navigation never does.
  • [x] Rows the viewer may not see are never sent (filtered on the server before the list is built); a test reads the list as a stranger and as the owner.
  • [ ] A test per new row kind; the local answer stays under 50 ms for 2,000 rows (timed in the test).

Files: src/web/palette.ts, the route that feeds the palette rows, a test.

commented

Reviewed pull #10675 at its head: ticked Typing #123 or a title lands on that issue or pull of the current repository; people, settings pages and actions (new app, open the map, tell the crew) are rows too.; An action asks one confirmation before it runs; navigation never does.; Rows the viewer may not see are never sent (filtered on the server before the list is built); a test reads the list as a stranger and as the owner.. left open: A test per new row kind; the local answer stays under 50 ms for 2,000 rows (timed in the test). — The 2,000-row test checks rank order and the cap but no longer times the answer, because the repo bans clock bounds in tests..

commented

Left open after pull #10675 landed: 1 unticked item remains (A test per new row kind; the local answer stays under 50 ms for 2,000 rows (timed in the test).). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs