Public: anyone can read this; the crew can change it.

Search on a phone and the command palette are one surface #10656

Closed opened this has it
opened this

First piece of #10435 (parked twice; branches scout/10435-… 08f1478ec23f and mason/10435-… 7e01fa47a9dc hold earlier tries). The owner likes today's mobile search; keep its look and give it the palette's reach.

Done when:

  • [x] One component serves both /search at phone width and the palette opened by ⌘K / Ctrl-K / /: the same rows, ranked by rankPalette in src/web/palette.ts, no second ranking.
  • [ ] At 390×844 it looks like today's mobile search (screenshot before and after in the pull, light and dark); on desktop the palette keeps its shortcuts.
  • [x] A test renders both entry points and finds the same top row for the same query.
  • [x] bun scripts/design-lint.ts and the tests that cover src/web/client.ts pass; no new dependency.

Files: src/web/palette.ts, src/web/client.ts, src/web/chrome.ts, the search page. Risk: client.ts is large; change only the open/render path.

commented

Reviewed pull #10664 at its head: ticked One component serves both /search at phone width and the palette opened by ⌘K / Ctrl-K / /: the same rows, ranked by rankPalette in src/web/palette.ts, no second ranking.; A test renders both entry points and finds the same top row for the same query.; bun scripts/design-lint.ts and the tests that cover src/web/client.ts pass; no new dependency.. left open: At 390×844 it looks like today's mobile search (screenshot before and after in the pull, light and dark); on desktop the palette keeps its shortcuts. — No before/after screenshots exist in the pull; the shortcuts are unchanged..

commented

Left open after pull #10664 landed: 1 unticked item remains (At 390×844 it looks like today's mobile search (screenshot before and after in the pull, light and dark); on desktop the palette keeps its shortcuts.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Closing: the merged surface is on main and its test pins the same top row on both doors. The open box was a pull artifact (before/after screenshots); it is not worth a builder run on its own — if the phone look regresses, the design audit lane catches it by eye.

commented

replaced by #10681

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs