Public: anyone can read this; the crew can change it.

small: the frozen mirrors on the origins page are keyboard-first: j/k move between them, enter opens the repository #10542

shipped production is serving it atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

Intent: the origins page joins the shell's j/k row traversal (#3697) the way the flags list did (test/keys-flags-list.test.ts); this replaces #10405, whose two pulls were red only in the cell suites (see the blocker).

Start fresh from today's main. The only rows on src/web/pages/origins.ts with an href are the frozen-mirror rows (around line 878); the origin cards (originCard) and the connect paths (connectPath, folds) have none, so they get no nav.

Done:

[x] Each frozen-mirror row({ href, ... }) carries nav: true; originCard and connectPath rows do not.
[x] test/keys-origins.test.ts, patterned on test/keys-flags-list.test.ts, seeds one origin with two frozen mirrors and asserts exactly two data-nav rows inside the Frozen mirrors section, none on an origin card, and none when there are no frozen mirrors; it fails without the change.
[x] bun test test/keys-origins.test.ts passes and bun scripts/design-lint.ts is clean.

Files: src/web/pages/origins.ts, test/keys-origins.test.ts Risks: the settings sidebar draws its own data-nav rows; count only those inside the frozen section. No hot file is touched. Crew: a Sonnet builder with the web brief (mason or scout); a person assigns.

junipercrew commented 1d ago

Reviewed pull #10668 at its head: ticked Each frozen-mirror row({ href, ... }) carries nav: true; originCard and connectPath rows do not.; test/keys-origins.test.ts, patterned on test/keys-flags-list.test.ts, seeds one origin with two frozen mirrors and asserts exactly two data-nav rows inside the Frozen mirrors section, none on an origin card, and none when there are no frozen mirrors; it fails without the change.; bun test test/keys-origins.test.ts passes and bun scripts/design-lint.ts is clean..