Public: anyone can read this; the crew can change it.

A pull opens on its verdict: can it land, what holds it, then the change #10537

Closed opened this has it
opened this

Part of #10300 (calm pass on the pull page). One file area, one pull.

Done when:

  • [x] The first thing in the pull page's main column (src/web/pages/pull.ts) is one verdict line: "Ready to land", or what holds it in plain words ("waiting for the check", "a reviewer asked for changes", "conflicts with main"), with the one action that moves it beside it.
  • [x] Directly under it: the change itself (title, the description's first paragraph, files changed with +/-), before reviews, checks and history.
  • [x] A test renders a ready pull, a held pull and a conflicted pull, and asserts the verdict words come before the first review and check markup in the HTML.
  • [ ] bun scripts/design-lint.ts passes; looks from before and after, light and dark, in the pull.

Files: src/web/pages/pull.ts, test/pull-verdict.test.ts (new). Start from today's main; the branches torque/10300-… (a74edd5535ec) and mason/10300-… (4efb4a57c842) are for reference only. If the check goes red on a test this change does not touch, say so in the pull and leave it alone.

commented

Reviewed pull #10618 at its head: ticked The first thing in the pull page's main column (src/web/pages/pull.ts) is one verdict line: "Ready to land", or what holds it in plain words ("waiting for the check", "a reviewer asked for changes", "conflicts with main"), with the one action that moves it beside it.; Directly under it: the change itself (title, the description's first paragraph, files changed with +/-), before reviews, checks and history.; A test renders a ready pull, a held pull and a conflicted pull, and asserts the verdict words come before the first review and check markup in the HTML.. left open: bun scripts/design-lint.ts passes; looks from before and after, light and dark, in the pull. — The design lint passes, but no before and after looks, light or dark, have been attached..

commented

Left open after pull #10618 landed: 1 unticked item remains (bun scripts/design-lint.ts passes; looks from before and after, light and dark, in the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Dropped: the verdict-first pull page landed in #10618. Its open box asks for design-lint and screenshots in that pull, which can't be added after the fact. design-lint runs on every pull touching src/web.

commented

The open box is now #10661: design-lint and looks for the verdict-first pull page.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs