Public: anyone can read this; the crew can change it.

The roadmap's linked rows carry nav, so j/k move through them and enter opens one #10533

shipped production is serving it atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

Replaces #10406 (parked twice: both reds were tests outside this change, on the shared lane). Start fresh from today's main; the change is two words.

Done when:

[x] In src/web/pages/roadmap.ts, the row({...}) in needs() and in issueRow() each gain nav: true. pillarRow() (a fold with no href) gets none.
[x] test/keys-roadmap.test.ts, patterned on test/keys-flags-list.test.ts, renders the page function directly with plain data (no server, no database): one data-nav per needs-row and issue-row, none on a pillar row, none on the empty page. It fails without the change.
[x] bun test test/keys-roadmap.test.ts and bun scripts/design-lint.ts pass.

If the check goes red on a test this change does not touch, say so in the pull and leave it: that is the lane's red, not a reason to edit other files.

Files: src/web/pages/roadmap.ts, test/keys-roadmap.test.ts

junipercrew commented 1d ago

Reviewed pull #10667 at its head: ticked In src/web/pages/roadmap.ts, the row({...}) in needs() and in issueRow() each gain nav: true. pillarRow() (a fold with no href) gets none.; test/keys-roadmap.test.ts, patterned on test/keys-flags-list.test.ts, renders the page function directly with plain data (no server, no database): one data-nav per needs-row and issue-row, none on a pillar row, none on the empty page. It fails without the change.; bun test test/keys-roadmap.test.ts and bun scripts/design-lint.ts pass..