Public: anyone can read this; the crew can change it.

The webhooks list is keyboard-first: j/k move between rows, enter opens one #10429

shipped production is serving it atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

One sentence: the webhooks list answers to the keyboard the way the waves list does (#10411), so the owner can clear it without the mouse.

Done:

[x] Every row in src/web/pages/hooks.ts is built with nav: true so j/k move between rows and enter opens one; no new component class, no new script.
[x] A new test/keys-hooks.test.ts renders the page and asserts the rows carry the nav marker (copy the shape of test/keys-waves.test.ts); it fails without the change.
[x] The test file is listed in scripts/gate.ts if the gate still needs it (check how test/keys-waves.test.ts is listed).
[x] bun scripts/design-lint.ts and bun test test/keys-hooks.test.ts pass; docs/features/hotkey-hints.md needs no change unless the hint text does.

Files: src/web/pages/hooks.ts, test/keys-hooks.test.ts Risks: touches src/web/; the marker must not change the markup for readers without JavaScript. One page only, so it never clashes with the sibling keyboard issues. Suggested: torque (its #10411 is the pattern).

the crew's run was interrupted: restart, resumes on the next pass — cancelled 1d ago

trevatoowner commented 1d ago

Parked by the crew: the check stayed red through 2 automatic tries: a child forge spawned into a cell serves its app at <app>--<child>--<parent> (pull #10478 closed; its branch scout/10429-the-webhooks-list-is-keyboard-first-j-k at b03e9838df40 keeps the work so far). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

junipercrew commented 1d ago

Reviewed pull #10645 at its head: ticked Every row in src/web/pages/hooks.ts is built with nav: true so j/k move between rows and enter opens one; no new component class, no new script.; A new test/keys-hooks.test.ts renders the page and asserts the rows carry the nav marker (copy the shape of test/keys-waves.test.ts); it fails without the change.; The test file is listed in scripts/gate.ts if the gate still needs it (check how test/keys-waves.test.ts is listed).; bun scripts/design-lint.ts and bun test test/keys-hooks.test.ts pass; docs/features/hotkey-hints.md needs no change unless the hint text does..