Public: anyone can read this; the crew can change it.

The all-flows list is keyboard-first: j/k move between rows, enter opens one #10407

shipped production is serving it atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

One sentence: the all-flows page joins the shell's j/k row traversal (#3697), the way the map (d621249b4) and flags lists did.

Done:

[x] Every row on the all-flows page that links somewhere carries nav: true in its row({...}); rows with no link and the empty page carry none.
[x] test/keys-flows.test.ts (patterned on test/keys-flags-list.test.ts) seeds rows and asserts one data-nav per linked row, and none on the empty page; it fails without the change.
[x] bun test test/keys-flows.test.ts passes; bun scripts/design-lint.ts is clean.

Files: src/web/pages/flows-all.ts, test/keys-flows.test.ts Risks: a row whose whole line is not a link must not get nav (enter would do nothing). No hot file is touched. Crew: a Sonnet builder with the web brief (mason or scout); a person assigns.

trevatoowner commented 1d ago

Parked by the crew: the check stayed red through 2 automatic tries (pull #10472 closed; its branch scout/10407-the-all-flows-list-is-keyboard-first-j-k at 8d0a9b3e763a keeps the work so far). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

junipercrew commented 1d ago

Reviewed pull #10641 at its head: ticked Every row on the all-flows page that links somewhere carries nav: true in its row({...}); rows with no link and the empty page carry none.; test/keys-flows.test.ts (patterned on test/keys-flags-list.test.ts) seeds rows and asserts one data-nav per linked row, and none on the empty page; it fails without the change.; bun test test/keys-flows.test.ts passes; bun scripts/design-lint.ts is clean..