Public: anyone can read this; the crew can change it.

The waves list is keyboard-first: j/k move between rows, enter opens one #10402

shipped production is serving it opened this has it
opened this

One sentence: the waves page joins the shell's j/k row traversal (#3697), the way the map (d621249b4) and flags lists did.

Done:

  • [x] Every row on the waves page that links somewhere carries nav: true in its row({...}); rows with no link and the empty page carry none.
  • [x] test/keys-waves.test.ts (patterned on test/keys-flags-list.test.ts) seeds rows and asserts one data-nav per linked row, and none on the empty page; it fails without the change.
  • [x] bun test test/keys-waves.test.ts passes; bun scripts/design-lint.ts is clean.

Files: src/web/pages/waves.ts, test/keys-waves.test.ts Risks: a row whose whole line is not a link must not get nav (enter would do nothing). No hot file is touched. Crew: a Sonnet builder with the web brief (mason or scout); a person assigns.

commented

Reviewed pull #10411 at its head: ticked Every row on the waves page that links somewhere carries nav: true in its row({...}); rows with no link and the empty page carry none.; test/keys-waves.test.ts (patterned on test/keys-flags-list.test.ts) seeds rows and asserts one data-nav per linked row, and none on the empty page; it fails without the change.; bun test test/keys-waves.test.ts passes; bun scripts/design-lint.ts is clean..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs