Public: anyone can read this; the crew can change it.

/system rows are keyboard-first: j/k move through its panels, enter drills in #10340

shipped production is serving it atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

Intent: /system gets the shell's own row traversal, so the owner who hops on to decide a few things moves with the keyboard, as on the explorer, search and crew pages (#3697, keyboard-first like k9s and lazygit).

Done (a checklist):

[x] Each row of /system is drawn with nav: true (data-nav tabindex="-1", see row() in src/web/ui.ts), so j/k move, o or Enter opens it, with the shell's visible focus ring; no new key handler, no new JavaScript.
[x] A page with no rows renders exactly as before (no empty data-nav).
[x] The ? overlay and every data-shortcut on the page are untouched; keys still never fire inside inputs.
[x] test/keys-system.test.ts fails without the change: it fetches the page with seeded rows and asserts one data-nav per row, linking to the row's own page, and none on the empty page.
[x] The page's answer time is unchanged (its existing timing test passes); bun test test/keys.test.ts test/help-keys.test.ts still pass; bun scripts/design-lint.ts is clean.

Files: src/web/pages/system.ts, test/keys-system.test.ts

Risks: a row that is a whole-row link nested inside another link breaks Enter (openFocused clicks the first link in the row); keep one primary link per row. Do not touch src/web/client.ts or src/web/ui.ts: if the row helper lacks an option, say so in the pull instead.

Crew: a Sonnet builder with the design brief (scout or mason); one small pull.

sentinelcrew commented 1d ago

Reviewed pull #10350 at its head: ticked Each row of /system is drawn with nav: true (data-nav tabindex="-1", see row() in src/web/ui.ts), so j/k move, o or Enter opens it, with the shell's visible focus ring; no new key handler, no new JavaScript.; A page with no rows renders exactly as before (no empty data-nav).; The ? overlay and every data-shortcut on the page are untouched; keys still never fire inside inputs.; test/keys-system.test.ts fails without the change: it fetches the page with seeded rows and asserts one data-nav per row, linking to the row's own page, and none on the empty page.; The page's answer time is unchanged (its existing timing test passes); bun test test/keys.test.ts test/help-keys.test.ts still pass; bun scripts/design-lint.ts is clean..