Public: anyone can read this; the crew can change it.

The runs list is keyboard-first: j/k move between runs, enter opens one #10338

Closed opened this
opened this

Intent: the runs list gets the shell's own row traversal, so the owner who hops on to decide a few things moves with the keyboard, as on the explorer, search and crew pages (#3697, keyboard-first like k9s and lazygit).

Done (a checklist):

  • [ ] Each row of the runs list is drawn with nav: true (data-nav tabindex="-1", see row() in src/web/ui.ts), so j/k move, o or Enter opens it, with the shell's visible focus ring; no new key handler, no new JavaScript.
  • [ ] A page with no rows renders exactly as before (no empty data-nav).
  • [ ] The ? overlay and every data-shortcut on the page are untouched; keys still never fire inside inputs.
  • [ ] test/keys-runs-list.test.ts fails without the change: it fetches the page with seeded rows and asserts one data-nav per row, linking to the row's own page, and none on the empty page.
  • [ ] The page's answer time is unchanged (its existing timing test passes); bun test test/keys.test.ts test/help-keys.test.ts still pass; bun scripts/design-lint.ts is clean.

Files: src/web/pages/runs.ts, test/keys-runs-list.test.ts

Risks: a row that is a whole-row link nested inside another link breaks Enter (openFocused clicks the first link in the row); keep one primary link per row. Do not touch src/web/client.ts or src/web/ui.ts: if the row helper lacks an option, say so in the pull instead.

Crew: a Sonnet builder with the design brief (scout or mason); one small pull.

commented

Done on main already, waiting for you to close it: 39df924cd60bcf6890a8bdea3628aa957a90a4bd

commented

Closed: already done on main in 39df924. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs