Public: anyone can read this; nobody can change it.

Each og card's cold-render budget is 300 ms on the machine it was set on, scaled by how much slower the plain card renders on this one #51

Merged opened this view on origin

Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.

Merged

The budget from #2490 was wall-clock: 300 ms on any machine. On main's check runner (half a CPU, 512 MiB) every design is ~6x slower, the plain repo card included (295 ms against 45 ms where the budget was set), and app and pull went red at 616 and 708 ms (run 889) with no change to the cards.

shipped merged

opened this view on origin

The budget from #2490 was wall-clock: 300 ms on any machine. On main's check runner (half a CPU, 512 MiB) every design is ~6x slower, the plain repo card included (295 ms against 45 ms where the budget was set), and app and pull went red at 616 and 708 ms (run 889) with no change to the cards.

The test now times the plain repo card first, in the same process, and scales the budget by max(1, plain / 45 ms). A machine as fast as the one the budget was set on, or faster, is held to the full 300 ms; a slow one gets a proportionally longer budget; and a design that grows slow against the plain card still goes red anywhere. Each test prints its measured budget.

Checked: on one third of a core, main's test goes red (pull 416 ms) and this one passes (budget x2.03, pull 335 ms); with 400 ms of extra work planted in the pull card, this one is still red on a fast machine (457 ms against 300).

<!-- pipeline:validation -->

Validation

pipeline/validate on bdc1cedf: pass in 10s — bun 1.3.14, CI-shaped env (scrubbed vars, runner PATH), exact check.yml shard + forge.json commands.

stepresulttime
bun install --frozen-lockfileok (exit 0)0s
forge.json check.fastok (exit 0)2s
check.yml gate (1) pull_requestok (exit 0)1s
check.yml gate (2) pull_requestok (exit 0)0s
check.yml gate (3) pull_requestok (exit 0)7s
  • ⚠️ node v20.19.2 here, v22 on CI (tsc runs under node)
test output (failures, totals)
▶ bun install --frozen-lockfile
  ok  exit 0  0s
▶ forge.json check.fast
Ran 107 tests across 8 files in 2.2s (8 shards).
  ok  exit 0  2s
▶ check.yml gate (1) pull_request
Ran 12 tests across 2 files in 0.1s (2 shards).
  ok  exit 0  1s
▶ check.yml gate (2) pull_request
Ran 12 tests across 3 files in 0.2s (3 shards).
  ok  exit 0  0s
▶ check.yml gate (3) pull_request
Ran 83 tests across 3 files in 6.7s (3 shards).
  ok  exit 0  7s
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs