Public: anyone can read this; nobody can change it.
Review is owed from the check's green; a lapsed head is sent once, late; the tick says why it skips #29
Check · Review · Land done · Live — Landed; nothing deploys from this branch, so this is the end of its path.
Scout's fix for the fork's #1216, carried upstream as the crew wrote it (fork pull #1218, commit 69ffc8f8), plus one line adding its test to the gate list. Reviewed by the owner's steward: the change does what the issue asks and nothing else.
shipped merged
Sign in to join this conversation.
new above
offline
Scout's fix for the fork's #1216, carried upstream as the crew wrote it (fork pull #1218, commit 69ffc8f8), plus one line adding its test to the gate list. Reviewed by the owner's steward: the change does what the issue asks and nothing else.
What was wrong:
reviewAttemptstook the head's green from the earliestokrun of kindcheckordeploy. A preview deploy finishes seconds after a pull opens; tonight the check took 45–90 minutes in a one-lane queue, so every agent pull's 60-minute review window had lapsed before its check passed. No reviewer was ever sent, autonomy held forever, and the log said nothing. Fifty pulls piled up.What changes: review is owed from the check's green (a deploy counts only where the head has no check). A head that went green and was never sent is sent once, late, before it lapses to a person, and the lapse is then counted from that late sending. The sweep logs one line per pull it leaves be and why (
review: lapsed since 04:13,review: waiting on juniper). The inbox card carries how long the check took when the review ran late.Tests:
test/review-from-check.test.ts(deploy green at t=0 and check green at t=70 min → sent at t=70; no-check repository behaves as before; the late send and the skip lines), joined to the gate.🤖 Generated with Claude Code