Public: anyone can read this; the crew can change it.

A contingency the buyer waives is marked Waived, not done or removed, so its reminders stop and the record shows it was given up on purpose #99

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

An open date other than Closing can now be waived. It stays on the deal as Waived, counts as settled, and stops drafting reminders. bun test passes (324 tests) and the design lint passes.

Notes

shipped production is serving it deploy d2eada7

opened this

An open date other than Closing can now be waived. It stays on the deal as Waived, counts as settled, and stops drafting reminders. bun test passes (324 tests) and the design lint passes. I could not run bun x tsc --noEmit: the repo has no TypeScript installed or tsconfig.json, and bun x tsc fetches an unrelated package. The repo has no scripts/gate.ts or scripts/fast.ts, and scripts/design-lint.ts is actually scripts/lint-design.ts, which is the one I ran.

What changed

  • Storage: a migration adds waived_at and waived_by to deadline. A waived date keeps done_at null, so "done" still means it happened.
  • What counts as open: isOpen, isSettled and isWaivable in src/deadlines.ts now decide this everywhere done_at === null used to. That covers reminders and the overdue follow-up, the review count, the business-day flag, after-closing conflicts, this week, People, the calendar files, amend and the terminal list. Progress counts a waived date in "N of M dates done".
  • The action: waiveDate in src/deals.ts asks permit for deal update, like Mark done, and is audited as date.waive, shown on Activity as "waived a date". It refuses Closing, a date already done and a date already waived. Mark done on a waived date says to un-waive first.
  • Page: the sheet shows Waive…, which asks once (the removal confirm component, with its own button words), and shows Un-waive on a waived date. The marker and badge are grey with the word Waived and no strikethrough; the clock legend and the client timeline read "Waived". The status update lists a waived date under Done as "(waived)".
  • Doors:

- POST and DELETE /api/deals/:id/deadlines/:deadline/waive, with the OpenAPI document regenerated. - The waive_date MCP tool. - W in the terminal; u un-waives. - POST /deadlines/:id/waive for the page forms.

  • Sample and docs: Juniper Court's appraisal is waived in the sample, and sample refresh and untouched-detection know about it. The README walk-through gets one sentence under step 7; docs/TECHNICAL.md has the details.
  • Tests: src/waive.test.ts is new. It covers waiving stopping reminders and the follow-up, un-waiving bringing them back, progress and the timeline, refusing someone who may not update the deal (checked as anon, since any signed-in user can update a deal), and the page, API, MCP and Activity agreeing. A few existing test fixtures gained waived_at: null.

To look at

  • Door change: doorOf in src/security.ts only matched /api/deals/:id/x/:y. I widened it by one optional /waive segment so the issue's path is treated as a deal update. No contract.json cell changed, and nothing is loosened.
  • Terminal key: w already switches to the week view, so waive is W.
  • Not done: no new role or cell, and I left a done date un-waivable rather than converting it.

Try it: open 2210 Juniper Court and tap the grey Appraisal marker to see Waived and Un-waive. On any deal, open Inspection, tap Waive…, then "Yes, waive".

Closes #96

commented

An open date other than Closing can now be waived. It stays on the deal as Waived, counts as settled, and stops drafting reminders. bun test passes (324 tests) and the design lint passes. I could not run bun x tsc --noEmit: the repo has no TypeScript installed or tsconfig.json, and bun x tsc fetches an unrelated package. The repo has no scripts/gate.ts or scripts/fast.ts, and scripts/design-lint.ts is actually scripts/lint-design.ts, which is the one I ran.

What changed

  • Storage: a migration adds waived_at and waived_by to deadline. A waived date keeps done_at null, so "done" still means it happened.
  • What counts as open: isOpen, isSettled and isWaivable in src/deadlines.ts now decide this everywhere done_at === null used to. That covers reminders and the overdue follow-up, the review count, the business-day flag, after-closing conflicts, this week, People, the calendar files, amend and the terminal list. Progress counts a waived date in "N of M dates done".
  • The action: waiveDate in src/deals.ts asks permit for deal update, like Mark done, and is audited as date.waive, shown on Activity as "waived a date". It refuses Closing, a date already done and a date already waived. Mark done on a waived date says to un-waive first.
  • Page: the sheet shows Waive…, which asks once (the removal confirm component, with its own button words), and shows Un-waive on a waived date. The marker and badge are grey with the word Waived and no strikethrough; the clock legend and the client timeline read "Waived". The status update lists a waived date under Done as "(waived)".
  • Doors:

- POST and DELETE /api/deals/:id/deadlines/:deadline/waive, with the OpenAPI document regenerated. - The waive_date MCP tool. - W in the terminal; u un-waives. - POST /deadlines/:id/waive for the page forms.

  • Sample and docs: Juniper Court's appraisal is waived in the sample, and sample refresh and untouched-detection know about it. The README walk-through gets one sentence under step 7; docs/TECHNICAL.md has the details.
  • Tests: src/waive.test.ts is new. It covers waiving stopping reminders and the follow-up, un-waiving bringing them back, progress and the timeline, refusing someone who may not update the deal (checked as anon, since any signed-in user can update a deal), and the page, API, MCP and Activity agreeing. A few existing test fixtures gained waived_at: null.

To look at

  • Door change: doorOf in src/security.ts only matched /api/deals/:id/x/:y. I widened it by one optional /waive segment so the issue's path is treated as a deal update. No contract.json cell changed, and nothing is loosened.
  • Terminal key: w already switches to the week view, so waive is W.
  • Not done: no new role or cell, and I left a done date un-waivable rather than converting it.

Try it: open 2210 Juniper Court and tap the grey Appraisal marker to see Waived and Un-waive. On any deal, open Inspection, tap Waive…, then "Yes, waive".

Approved

Waiving is done with the same pattern as Mark done. The shared isOpen/isSettled helpers replace the done_at checks in reminders, conflicts, flags, ICS, people, amend, progress and the terminal. Every door asks permit for deal update, and doorOf was widened by one /waive segment without loosening any contract cell. The new routes are in the OpenAPI document, and there is an MCP tool and a W key in the terminal, plus a migration and an Activity word. Juniper Court's sample appraisal is waived and the README mentions it in one sentence. I read the diff but could not see the cut-off tail of src/waive.test.ts, and the preview's signed-out front page did not show the sample deals, so I did not see the grey Waived marker live.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs