Public: anyone can read this; the crew can change it.
Every reminder signs off with the agent's name, brokerage, phone and email, and the README says how to make the app carry your own #41
Check · Review · Land · Live done — Landed and live in production.
Every new reminder draft now ends with a two-line sign-off, Name, Brokerage then phone · email. The agent's phone and email also show in the header, the client timeline and the terminal. What changed Settings: src/env.ts reads DEALCLOCKPHONE and DEALCLOCKEMAIL, defaulting to (555) 010-0142 and [email protected].
shipped production is serving it deploy d2eada7
1 earlier comment · 1 event
Every new reminder draft now ends with a two-line sign-off, Name, Brokerage then phone · email. The agent's phone and email also show in the header, the client timeline and the terminal.
What changed
- Settings:
src/env.tsreadsDEAL_CLOCK_PHONEandDEAL_CLOCK_EMAIL, defaulting to(555) 010-0142and[email protected]. - Validation: a phone must be digits, spaces and
+ ( ) - ., at most 30 characters. An email must have one@and at most 254 characters. A bad value falls back to the sample and logs oneDEAL_CLOCK_…line, with no crash. - Drafts:
Agentinsrc/reminders.tscarriesphoneandemail. A newsignOff()writes the sign-off. The page, MCP and/tickall use the samedrafts/draftsForpath, so their draft words are identical. A sent reminder still reads back the words that were approved. - Pages: the header and client timeline show the phone as a
tel:link and the email as amailto:link, both escaped. The terminal header and its client timeline print them as plain text. A small.agent-contactrule instatic/app.cssstyles the line. - Docs: README has a Make it yours section, and
docs/TECHNICAL.mdlists the four variables. - Tests: the new
src/signoff.test.tscovers the sign-off format, sent words surviving an agent change, validation, the boot fallback with its log line, and the timeline links. Existing tests only gainedphoneandemailon their test agents; no expected draft text changed.
Checks
- The full
bun testpasses (135 tests). bun scripts/lint-design.tsprinted nothing. This repo has noscripts/design-lint.ts, so I ran itslint-design.tsinstead.- I could not run
bun x tsc --noEmit.bun xpulled in a TypeScript 7 compiler that only prints its help text in this sandbox, so the type check has not run. The forge's check will cover it.
No contract cell changed. I did not add a mailto/tel control to the terminal beyond plain text.
To try it: set DEAL_CLOCK_PHONE and DEAL_CLOCK_EMAIL, open any deal's reminder draft, and look at the header and /deals/:id/timeline.
🤖 Generated with Claude Code
The sign-off and settings work and the contract is untouched, but two shipped behaviours have no test and there are a few cleanups. Fix these in one round:
- FIRST: add tests for the header contact line (layout) and the terminal header and client timeline. Both are new behaviour, and
signoff.test.tsonly covers the timeline page. Each test must fail if the line is removed. - Move the
/** Whose deals these are ... */comment insrc/env.tsback ontoagent. It now sits overPHONE_PATTERN. - The tel/mailto markup is copied into
layout.tsandtimeline.ts. Extract one helper, for examplecontactLinks(agent)in a small module, and use it in both. - Email validation accepts
?,&and#, so[email protected]?bcc=xwould pass and become a mailto query. Reject those characters, or encode the address in the href, and test it. bun x tsc --noEmitwas not run. Run it, or state in the pull that the forge check will cover it.
No contract cell was loosened, and the draft path is shared by the page, MCP and /tick.
All five review points are addressed and pushed in 2a23e47. The full bun test passes (138 tests) and scripts/lint-design.ts printed nothing.
- Tests for the new lines (
src/signoff.test.ts):
- One test checks that the header from layout() has the agent-contact line with the tel: and mailto: links.
- One test checks that the terminal header and its client timeline both print (555) 010-0142 · [email protected].
- Each fails if its line is removed.
- Comment moved: the
Whose deals these arecomment is back onagentinsrc/env.ts. The two validators now sit under their own comment. - One helper:
contactLinks(agent)lives in the newsrc/pages/contact.ts.layout.tsandtimeline.tsboth use it, and a test checks that it escapes what it is given. - Email validation: the address is now an allowlist,
[A-Za-z0-9._+-]before the@and[A-Za-z0-9.-]after it. That rejects?,&and#, so[email protected]?bcc=xfalls back to the sample. A test covers four injecting forms. tsc: I could not run it. The repo has notsconfig.json, andbun x tscfetches a TypeScript 7 compiler that only prints its help text in this sandbox. The forge's check will cover the type check.
No contract cell changed.
🤖 Generated with Claude Code
All five earlier asks are met: tests for the header and terminal lines, the env comment restored, one contactLinks helper, an allowlist email check that rejects ?, & and #, and the tsc note. Settings are validated at boot with a logged fallback, output is escaped, tel: gets digits only, and no contract cell changed. The terminal prints the same contact line as the page. Non-blocking: the last sentence in docs/TECHNICAL.md Settings is now one long line and could be rewrapped.
Every new reminder draft now ends with a two-line sign-off,
Name, Brokeragethenphone · email. The agent's phone and email also show in the header, the client timeline and the terminal.What changed
src/env.tsreadsDEAL_CLOCK_PHONEandDEAL_CLOCK_EMAIL, defaulting to(555) 010-0142and[email protected].+ ( ) - ., at most 30 characters. An email must have one@and at most 254 characters. A bad value falls back to the sample and logs oneDEAL_CLOCK_…line, with no crash.Agentinsrc/reminders.tscarriesphoneandemail. A newsignOff()writes the sign-off. The page, MCP and/tickall use the samedrafts/draftsForpath, so their draft words are identical. A sent reminder still reads back the words that were approved.tel:link and the email as amailto:link, both escaped. The terminal header and its client timeline print them as plain text. A small.agent-contactrule instatic/app.cssstyles the line.docs/TECHNICAL.mdlists the four variables.src/signoff.test.tscovers the sign-off format, sent words surviving an agent change, validation, the boot fallback with its log line, and the timeline links. Existing tests only gainedphoneandemailon their test agents; no expected draft text changed.Checks
bun testpasses (135 tests).bun scripts/lint-design.tsprinted nothing. This repo has noscripts/design-lint.ts, so I ran itslint-design.tsinstead.bun x tsc --noEmit.bun xpulled in a TypeScript 7 compiler that only prints its help text in this sandbox, so the type check has not run. The forge's check will cover it.No contract cell changed. I did not add a mailto/tel control to the terminal beyond plain text.
To try it: set
DEAL_CLOCK_PHONEandDEAL_CLOCK_EMAIL, open any deal's reminder draft, and look at the header and/deals/:id/timeline.🤖 Generated with Claude Code
Closes #36