Public: anyone can read this; the crew can change it.

A signed-out visitor lands on a page that shows what deal-clock does, with a picture of the clock made from made-up data, and one Sign in button #32

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

I merged main into this branch, resolved the three conflicts, and pushed. All 117 tests pass. I did not run the type check, the gate script or the design lint, because none of them could run here.

Notes

shipped production is serving it deploy d2eada7

opened this

I merged main into this branch, resolved the three conflicts, and pushed. All 117 tests pass. I did not run the type check, the gate script or the design lint, because none of them could run here.

  • Type check: the repository has no tsconfig.json, so bun x tsc --noEmit just prints its help.
  • Gate and design lint: scripts/gate.ts and scripts/design-lint.ts don't exist in this clone.

How each conflict was resolved:

  • src/routes.ts: I kept both imports, welcomePage from this branch and timelinePage from main.
  • src/pages/layout.ts: I kept both options, live from this branch and plain and bodyClass from main. The live.js script is left out when either plain is set or live is false. The <body> tag carries bodyClass when one is given.
  • static/app.css: I kept both the welcome-page styles and main's client-timeline styles.

The merge commit is 2bd5305.

Continues #32

1 earlier comment · 1 event
commented

I merged main into this branch, resolved the three conflicts, and pushed. All 117 tests pass. I did not run the type check, the gate script or the design lint, because none of them could run here.

  • Type check: the repository has no tsconfig.json, so bun x tsc --noEmit just prints its help.
  • Gate and design lint: scripts/gate.ts and scripts/design-lint.ts don't exist in this clone.

How each conflict was resolved:

  • src/routes.ts: I kept both imports, welcomePage from this branch and timelinePage from main.
  • src/pages/layout.ts: I kept both options, live from this branch and plain and bodyClass from main. The live.js script is left out when either plain is set or live is false. The <body> tag carries bodyClass when one is given.
  • static/app.css: I kept both the welcome-page styles and main's client-timeline styles.

The merge commit is 2bd5305.

Changes requested — before the latest push

Works in the preview: signed-out / shows the headline, three points, a still made-up clock, no deal is read, no script, security headers present, no contract cell touched. One change: the issue asks for ONE Sign in button, but the page renders two (the header one from layout plus this body one). Fix: render a single Sign in on this page, e.g. have layout skip the header door when the page supplies its own (or drop the body button and keep the header one only if the issue allows), and add a test asserting the guest page contains exactly one Sign in link. Minor: routes.ts imports welcomePage out of alphabetical order next to timelinePage.

commented

The signed-out page at / now has exactly one Sign in button. The tests in src/server.test.ts pass; I ran no other suite.

  • Sign in: I removed the body button from src/pages/welcome.ts and kept the layout's header one. The Sign in link in the header goes to /__forge/signin?to=%2F.
  • Test: the guest-page test now asserts the page contains exactly one >Sign in<. Its existing href check had to change from to=/ to to=%2F, because the header link encodes the slash.
  • Imports: in src/routes.ts, timelinePage now comes before welcomePage.
  • Not run:

- bun x tsc --noEmit printed only tsc's help text, so there was no type check. - There is no scripts/gate.ts, and scripts/design-lint.ts doesn't exist. - scripts/lint-design.ts printed nothing, so I took that as clean.

No contract cell changed. To try it, open the preview signed out and look for a single Sign in link, in the header.

🤖 Generated with Claude Code

Approved

Earlier ask met: the signed-out page now has exactly one Sign in (the header link), asserted by a test and confirmed on the preview, which ships no script. No deal is read for anon, no contract cell is loosened, and the security headers are kept and tested. Non-blocking: the file header comment in src/pages/welcome.ts wraps unevenly.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs