The agent chooses a warm or a brief voice for reminder drafts on the Profile page #301

The Profile page now has a voice choice, Warm (default) or Brief, and every new draft uses the one chosen. The new voice tests, the profile, leak and migration suites, and bun scripts/lint-design.ts pass. I did not run the full suite or tsc --noEmit: the clone has no tsconfig.json or package.json, and scripts/gate.ts and scripts/fast.ts don't exist.

What changed

• Wording: src/reminders.ts takes the voice from the agent and writes the two voices as two bodies over the same facts. The date, place, who owes what, the earnest-money line, the sign-off and the agent's own line are built once. Subjects are identical in both voices.
• Brief: it covers every draft kind (reminders, date-changed notices, status updates, check-ins and home anniversaries), and it drops the pleasantry paragraphs. The check-in and anniversary templates live in src/checkin.ts, so Brief is there too.
• Saving:

- src/profile.ts validates the voice against warm and brief and refuses anything else with a 422 naming voice. The save goes through the same permit check and same-origin door as the rest of the profile. A client that omits the voice keeps the saved one. - Only Brief is stored as a choice; Warm reads back as no voice at all, so the existing profile API tests stand unchanged. - The JSON schema and the form carry the field.

• Migration: one ALTER TABLE profile ADD COLUMN voice, appended at the end of the list. In src/migrations.test.ts I added it to the filter of later migrations that the "before the Profile line" test strips, since that test builds a database from an earlier schema.
• Profile page: a radio choice plus a sample of each voice, drawn from the first deal with an unsent draft and rendered on the server with no JavaScript. src/voice.ts builds the samples.
• Existing drafts: a draft already sent or held keeps its words, as it did before. I added no test for this; the unit test only compares two voices' output and doesn't send or hold a draft first.
• Docs and tests: README's Profile paragraph and the TECHNICAL.md file table mention it. New tests are in src/leaks.test.ts, src/voice.test.ts and src/voice.routes.test.ts. Between them they check:

- both voices pass the leak test for every sample deal draft; - Brief is shorter than Warm for each draft; - a bad voice is refused; - a user cannot change the voice; - a cross-site save is refused; - the page shows both samples.

What I did not do

• No contract.json change.
• No hold or review page code touched, so #292 is untouched.
• No voice prompt in the terminal profile editor; it keeps whatever voice is saved.

Try it Open /profile on the preview, pick Brief and save. Then open Review and compare a draft's wording.

🤖 Generated with Claude Code

Closes #297

The Profile page now has a voice choice, Warm (default) or Brief, and every new draft uses the one chosen. The new voice tests, the profile, leak and migration suites, and bun scripts/lint-design.ts pass. I did not run the full suite or tsc --noEmit: the clone has no tsconfig.json or package.json, and scripts/gate.ts and scripts/fast.ts don't exist.

What changed

• Wording: src/reminders.ts takes the voice from the agent and writes the two voices as two bodies over the same facts. The date, place, who owes what, the earnest-money line, the sign-off and the agent's own line are built once. Subjects are identical in both voices.
• Brief: it covers every draft kind (reminders, date-changed notices, status updates, check-ins and home anniversaries), and it drops the pleasantry paragraphs. The check-in and anniversary templates live in src/checkin.ts, so Brief is there too.
• Saving:

- src/profile.ts validates the voice against warm and brief and refuses anything else with a 422 naming voice. The save goes through the same permit check and same-origin door as the rest of the profile. A client that omits the voice keeps the saved one. - Only Brief is stored as a choice; Warm reads back as no voice at all, so the existing profile API tests stand unchanged. - The JSON schema and the form carry the field.

• Migration: one ALTER TABLE profile ADD COLUMN voice, appended at the end of the list. In src/migrations.test.ts I added it to the filter of later migrations that the "before the Profile line" test strips, since that test builds a database from an earlier schema.
• Profile page: a radio choice plus a sample of each voice, drawn from the first deal with an unsent draft and rendered on the server with no JavaScript. src/voice.ts builds the samples.
• Existing drafts: a draft already sent or held keeps its words, as it did before. I added no test for this; the unit test only compares two voices' output and doesn't send or hold a draft first.
• Docs and tests: README's Profile paragraph and the TECHNICAL.md file table mention it. New tests are in src/leaks.test.ts, src/voice.test.ts and src/voice.routes.test.ts. Between them they check:

- both voices pass the leak test for every sample deal draft; - Brief is shorter than Warm for each draft; - a bad voice is refused; - a user cannot change the voice; - a cross-site save is refused; - the page shows both samples.

What I did not do

• No contract.json change.
• No hold or review page code touched, so #292 is untouched.
• No voice prompt in the terminal profile editor; it keeps whatever voice is saved.

Try it Open /profile on the preview, pick Brief and save. Then open Review and compare a draft's wording.

🤖 Generated with Claude Code

I merged main into this branch and pushed it. The merge is commit 9008d24.

• Conflicts: Both were in src/db.ts and src/migrations.test.ts, and both came from this branch and main each adding a migration at the end of the list. I kept both. main's paper table migration comes first, because the migration pin test fixes migrations by position and main had already landed it. This branch's profile.voice column comes after it. In the migrations test, the filter for pre-Profile databases now excludes both migrations.
• OpenAPI file: contract/openapi.json was stale after the merge, so I re-emitted it with bun run contract:emit.
• Tests: The migration, OpenAPI and reminder tests pass (7 tests).
• Full suite: It ran 803 tests and 7 failed. The failures were the "answers in under 50 ms" and "within budget" timing checks, and the OpenAPI check, which the re-emit fixed. I read the timing failures as slowness from running the whole suite at once. I did not re-run the full suite, so I haven't confirmed that. The forge's check on this push will show it.
• Type check: bun x tsc --noEmit printed only its help text, so I can't say it passed. The forge's check will show whether types are clean.
• Not committed: Stray dotfiles in the clone, such as .bash_profile and .claude/, are not part of the commit.

The preview's deploy test failed on six timing tests in src/speed.test.ts. I found nothing in this pull that causes them, so I made no change and pushed nothing this turn. The merge from the last turn (9008d24) is still the tip.

• What failed: the six are "reminder review / people answers in under 50 ms with 200 deals" and four "answers within budget the first time after a deal changes" tests (clock, reminder review, people, clock with closed deals).
• Not from this pull: src/speed.test.ts fails the same six tests on origin/main (3764f8c). It also fails the same tests, plus a few others in some runs, on 9bacaa2, 3a44623 and 6b38028, all before the paperwork checklist or this pull's voice column.
• Not slow in the app: I timed the People request inside the server. The handler took about 4.5 ms, with 0.3 ms in people() and 0.2 ms in gzip. The same test run alone measures about 50 ms per request from the client. Within the whole file it climbs to about 1.5 s, so the extra time is outside the app's own work.
• Sandbox: this machine's load average was about 81 on 80 cores, so absolute timings here are not trustworthy.
• What I did not establish: I did not find what makes the requests slower within the full file than when the test runs alone. The tests that follow earlier ones in that file may be the cause. A person should look at whether main itself passes the forge's check.

I did not loosen or raise any timing budget to get a green check. That would hide the problem rather than fix it. This pull adds the warm or brief voice setting on the Profile page and merges main (migration order: paper, then voice).

If the forge shows main green on this test, tell me and I'll dig into the speed test's cumulative slowdown next.

I merged main into this branch and pushed it (e2f0bdd). I did not run the full suite. The migration, voice and OpenAPI tests pass (10 tests, 0 failures), but the type check and the speed tests did not run.

• Conflicts: src/db.ts and src/migrations.test.ts conflicted because main added the deadline_move.undo migration at the end of the list, where this branch adds profile.voice. I put main's undo migration first, since it has already landed and migrations are pinned by position, and this branch's voice migration after it. The pre-Profile filter in the migrations test now excludes both columns.
• OpenAPI: contract/openapi.json was re-emitted after the merge.
• Speed tests: On the last deploy, six timing tests in src/speed.test.ts failed ("answers in under 50 ms" and "within budget"). The same ones fail on main and on commits before this branch, so they are not caused by this pull. I did not rerun them here.
• Behaviour: The warm or brief voice for reminder drafts is unchanged by this merge, and no policy cells were loosened.

All four review points are addressed and pushed (e803b7a). The full suite passes (821 tests), but I could not run the type check or the gate here.

1. A held draft keeps its words. The bug was real. A hold with no edit stored empty words, so the draft was re-rendered in whatever voice was current. holdReminder in src/deals.ts now stores the draft's words at hold time. The new test in src/voice.test.ts sends one draft, holds one after editing it, and holds one plainly. It then saves brief and asserts all three are word-for-word unchanged, and that an untouched draft does take the new voice. I confirmed the test fails without the fix.

2. One set of facts, two templates. The new src/wording.ts holds Voice and VOICES, a Facts type, and two template functions, warm and brief. src/reminders.ts builds each message's facts once and calls say(facts, voice). That covers the reminder, late, moved, amended-dates, check-in, anniversary and status messages, and the subjects are shared. I removed the duplicate wording from checkin.ts and the voice?: string parameter.

3. Terminal and MCP.

• The terminal profile editor in src/terminal.ts (the file is terminal.ts, not tty.ts) has a voice step and shows the voice. It goes through setProfile, so it is admin-only like the page.
• A new terminal test covers saving brief, refusing a bad voice, and a user being refused.
• The existing terminal profile tests needed one extra Enter for the new step.
• set_profile in MCP accepts voice too. I added no MCP test for it.
• The README and docs/TECHNICAL.md say so.

4. Tidy-ups. I fixed the split imports and trailing comma in the voice tests, the _id/_saved destructures and ! in src/voice.ts, and the cast in the profile page. I removed the stray Voice re-export from profile.ts, and the misindented ternary is gone with the rewrite. The README paragraph is rewrapped.

Not run: scripts/gate.ts does not exist in this repo, and the repo has no tsconfig.json or installed type packages, so bun x tsc --noEmit only prints help. The forge's check will be the first real type check.

Behaviour change: a plainly held draft now keeps the words it had when held. It no longer refreshes if the deal's details change while it waits. That matches how sent and edited drafts already behave.

I merged main into this branch and pushed it (c5c4928). The full suite passes (828 tests, 0 failures), including the speed tests. I did not run a type check; the repo has no tsconfig.json, as noted in my last report.

• Migrations (src/db.ts, src/migrations.test.ts): main added the deal.note migration at the end of the list, where this branch adds profile.voice. I kept both, with main's note first and voice after it, since migrations are pinned by position. The pre-Profile filter in the migrations test now excludes both columns.
• Terminal (src/terminal.ts): only the header comment conflicted. I kept this branch's "time zone and voice" wording for the profile line and main's new K private-note text for the deal line.
• OpenAPI: I re-emitted contract/openapi.json.
• First failure was a stale file, not code: one src/commission.test.ts test failed at first. A leftover :memory: database directory in my clone had been created at the old migration order, so it recorded voice as applied and never ran note. I deleted it and the suite went green.
• Preview database: a database created by an earlier push of this branch would have the same problem, because voice used to sit before note. I believe the preview deploy starts from a fresh database. If it reuses an old one, delete it. Production is unaffected, since main has never had voice.

No policy cells changed.