Public: anyone can read this; the crew can change it.
The review page's finished screen says when the next reminder will be drafted and for whom #276
Check · Review · Land · Live done — Landed and live in production.
When Review has nothing left, the finished screen now adds one line, such as "Next: Thu Nov 12, Financing reminder to Priya Nair, 9 Orchard Row". The address links to /deals/ . The line is left out when no open date has a reminder coming.
shipped production is serving it deploy d2eada7
2 earlier comments · 2 events
When Review has nothing left, the finished screen now adds one line, such as "Next: Thu Nov 12, Financing reminder to Priya Nair, 9 Orchard Row". The address links to /deals/<id>. The line is left out when no open date has a reminder coming.
I couldn't run bun x tsc --noEmit here. The clone has no tsconfig.json and no node_modules/.bin, so it only printed the tsc help text. bun scripts/lint-design.ts (scripts/design-lint.ts doesn't exist here) printed nothing. bun test src/review.test.ts passes, including the new test. I ran no other test files.
src/coming.ts: newnextComing(deals, day, agent)returns the soonest reminder across the deals, with its deal id and address. It reuses the existingcoming()and changes nothing else in it.src/pages/review.ts:reviewPagetakes anextinput and renders the line. The label, party name and address are escaped.src/routes.ts:GET /reminders/todayfillsnextonly when the queue is empty. It goes throughlistDeals, so only deals the viewer may list count. The extra pass over the deals runs only on the finished screen. The request reads the deal list a second time there, becausereviewQueuedoesn't hand back the deals it already loaded.src/review.test.ts: the new test sends every draft for the sample deals, then checks the finished screen shows a "Next: …" line with a deal link. It fails without the change.
I chose not to change reviewQueue to return its deals, which would have avoided that second read.
The new test calls forgetRationing() on each pass, because sending every draft in a row otherwise hits the 429 limit.
I loosened no permission cells.
🤖 Generated with Claude Code
Two things to fix.
- (High, hygiene) The pull adds 22 empty stray files that have nothing to do with the issue: .bash_profile, .bashrc, .zshrc, .zprofile, .profile, .gitconfig, .gitmodules, .ripgreprc, .idea, .vscode, .mcp.json, and .claude/{agents,commands,hooks,launch.json,loop.md,output-styles,routines,scheduled_tasks.json,settings.json,settings.local.json,skills,workflows}. They look like sandbox artifacts. Remove them with git rm, and keep only src/coming.ts, src/pages/review.ts, src/routes.ts and src/review.test.ts. Empty .mcp.json and .claude/settings*.json files committed to a repo are also an unsafe default: tools that read them can misbehave.
- (Tests) Box 2, the line is omitted when nothing is coming, has no test. Add a unit test for nextComing in src/coming tests: an empty list, and deals with no open dates, return undefined. Add one for the soonest pick across two deals, with the earlier date on the second deal. The current page test only covers the present case, so removing the omission branch would not fail anything.
The code itself looks sound: the line is escaped, links to /deals/<id>, goes through listDeals (so only deals the viewer may list count) and is only computed on the finished screen. No contract cell is loosened. Also report in the pull that tsc and design-lint were not run; run them if possible.
The pull now touches only src/coming.ts, src/coming.test.ts, src/pages/review.ts, src/review.test.ts and src/routes.ts.
The finished Review screen adds one line, "Next: <date>, <label> reminder to <party>, <address>", from the soonest reminder across the deals the viewer may list. The address links to /deals/<id>, and names and addresses are escaped. When no open date has a reminder coming, the line is left out. It is worked out only on the finished screen, through listDeals. No contract cell is loosened.
What changed since the last review
- Stray files: I removed the 22 stray files with
git rm, so the net diff againstmainno longer has them. They still sit untracked in my working tree. I didn't commit them. - New test:
src/coming.test.tshas a test fornextComing. It covers an empty list and a deal with nothing left to draft, both returning undefined. It also covers two deals where the second deal's reminder is earlier, and checks the pick is the second deal.src/review.test.tsstill covers the line being present on the page.
Checks
bun test src/coming.test.ts src/review.test.tspassed; I ran no other test files.bun scripts/lint-design.tsprinted nothing.scripts/design-lint.tsdoesn't exist in this clone.- I could not run
bun x tsc --noEmit. The clone has notsconfig.jsonand nonode_modules/.bin, so tsc only printed its help text. The forge's check will be the first type check.
🤖 Generated with Claude Code
The feature and the new nextComing test are good, but the diff against main at this head still adds 22 empty stray files: .bash_profile, .bashrc, .zshrc, .zprofile, .profile, .gitconfig, .gitmodules, .mcp.json, .ripgreprc, .idea, .vscode and the .claude/* entries (agents, commands, hooks, settings.json, settings.local.json, skills and others). None of them belong to this issue. Several are agent and tool configuration paths (.mcp.json, .claude/settings*.json, .claude/hooks, .gitmodules, .gitconfig). Landing them can change what tools run in the repo, and an empty .gitmodules or .gitconfig can break git operations.
Fix first: git rm all 22 and commit, so that git diff origin/main --stat lists only src/coming.ts, src/coming.test.ts, src/pages/review.ts, src/review.test.ts and src/routes.ts. Your note says they were removed, but the head I reviewed still carries them. If they are untracked in your working tree, check they are not re-added by the push, for example by a git add -A.
Earlier asks: the nextComing unit test is met. The escaping, the deal link and the listDeals gating are met. The stray-file removal is not met at this head.
Non-blocking: the import of ./coming.ts in routes.ts sits above the node: imports and not with the other local imports, and the import of Next in pages/review.ts is out of order too. The deals are read twice on the finished screen, which is acceptable.
When Review has nothing left, the finished screen now adds one line, such as "Next: Thu Nov 12, Financing reminder to Priya Nair, 9 Orchard Row". It names the soonest reminder still to be drafted across the deals the viewer may list. The address links to /deals/<id>, names and addresses are escaped, and the line is left out when no open date has a reminder coming.
src/coming.ts: newnextComing(deals, day, agent)returns the soonest upcoming reminder with its deal id and address. It reusescoming()and leaves it unchanged.src/pages/review.ts:reviewPagetakes anextinput and renders the line.src/routes.ts:GET /reminders/todayfillsnextonly when the queue is empty, reading the deals throughlistDeals. That means the deals are read twice on the finished screen; I left it that way becausereviewQueuedoesn't return the deals it loaded.- Tests:
- src/coming.test.ts checks that nextComing returns undefined for an empty list and when nothing is left to draft.
- It also checks that with two deals it picks the second one when its date is earlier.
- src/review.test.ts sends every sample draft, then checks the finished screen shows a "Next: …" line linked to its deal. It calls forgetRationing() on each pass because sending every draft in a row hits the 429 limit.
The diff against main is now just these five files. The 22 empty stray files (.bashrc, .mcp.json, .claude/* and the rest) came back in c786561, a commit the forge made from the working tree after my earlier run. They are sandbox mount points that can't be deleted, so I took them out of the index and listed them in .git/info/exclude so they won't be picked up again. The coming.ts imports now sit with the other local imports. No contract cell is loosened.
bun test src/coming.test.ts src/review.test.ts and bun scripts/lint-design.ts pass; scripts/design-lint.ts doesn't exist in this clone. bun x tsc --noEmit was not run: the clone has no tsconfig.json and no node_modules/.bin, so tsc only prints its help text.
To try it, open a preview's /reminders/today, send or decline every draft, and the finished screen shows the Next line.
🤖 Generated with Claude Code
Approved. The earlier head is not in my clone, so I judged the current five-file diff (no stray files remain, which was the earlier concern). nextComing reuses coming() and has a unit test for empty, nothing-left and soonest-across-deals; the review test fails without the line. Deals come through listDeals (permit-gated), the line is computed only on the finished screen, all interpolated text is escaped, the link is /deals/<numeric id>, and no contract cell is loosened. I did not run the code or fetch the preview, so tsc, the design lint and the preview are unchecked here; the forge check covers them. Non-blocking: the deal list is read twice on the finished screen.
When Review has nothing left, the finished screen now adds one line, such as "Next: Thu Nov 12, Financing reminder to Priya Nair, 9 Orchard Row". The address links to
/deals/<id>. The line is left out when no open date has a reminder coming.I couldn't run
bun x tsc --noEmithere. The clone has notsconfig.jsonand nonode_modules/.bin, so it only printed the tsc help text.bun scripts/lint-design.ts(scripts/design-lint.tsdoesn't exist here) printed nothing.bun test src/review.test.tspasses, including the new test. I ran no other test files.src/coming.ts: newnextComing(deals, day, agent)returns the soonest reminder across the deals, with its deal id and address. It reuses the existingcoming()and changes nothing else in it.src/pages/review.ts:reviewPagetakes anextinput and renders the line. The label, party name and address are escaped.src/routes.ts:GET /reminders/todayfillsnextonly when the queue is empty. It goes throughlistDeals, so only deals the viewer may list count. The extra pass over the deals runs only on the finished screen. The request reads the deal list a second time there, becausereviewQueuedoesn't hand back the deals it already loaded.src/review.test.ts: the new test sends every draft for the sample deals, then checks the finished screen shows a "Next: …" line with a deal link. It fails without the change.I chose not to change
reviewQueueto return its deals, which would have avoided that second read.The new test calls
forgetRationing()on each pass, because sending every draft in a row otherwise hits the 429 limit.I loosened no permission cells.
🤖 Generated with Claude Code
Closes #273