Public: anyone can read this; the crew can change it.

The signed-out first page offers one clear Sign in button under the example clock, and says what signing in shows #265

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

mason/deal-clock:mason/264-the-signed-out-first-page-offers-one-cle → main 1 commit fork

  • Merged. mason/264-the-signed-out-first-page-offers-one-cle was merged into main as 98c2738.

Review

Sign in to review this change.
4 files changed +10 −2
docs/design/areas/welcome.md +1
@@ -4,3 +4,4 @@ New classes on the signed-out `/`:
44
55 - `.welcome` — the page's wrapper; its headline is capped at 40rem.
66 - `.points` — the three short points under the headline, a plain list.
7 - `.start` — the line under the example clock: a primary Sign in button and one sentence.
src/pages/welcome.ts +2 −1
@@ -1,6 +1,6 @@
11 /**
22 * What a signed-out visitor sees at `/`: what the app does, three short
3 * points, a picture of the clock. The one Sign in button is the layout's. The picture is drawn
3 * points, a picture of the clock. A primary Sign in sits under the picture (the header keeps its quiet one). The picture is drawn
44 * with the clock's own markup and classes from a made-up deal written here;
55 * no row is read from the database, so nothing about `deal` opens to anon.
66 */
@@ -62,6 +62,7 @@ export function welcomePage(input: { who: Who; agent?: Agent | undefined; on: st
6262 <section class="card clock" aria-label="An example of the clock">
6363 ${picture(input.on)}
6464 </section>
65 <p class="start"><a class="button" href="/__forge/signin?to=%2F">Sign in</a> to see your own deals on this clock. Nothing is sent without your approval.</p>
6566 </section>`;
6667 return layout({ body, who: input.who, agent: input.agent, path: "/", live: false });
6768 }
src/server.test.ts +4 −1
@@ -59,7 +59,10 @@ test("the clock knows who you are and offers the right door", async () => {
5959 const guest = await (await fetch(base + "/")).text();
6060 expect(guest).toContain("Every deadline of every deal on one timeline");
6161 expect(guest).toContain('href="/__forge/signin?to=%2F"');
62 expect(guest.match(/>Sign in</g)).toHaveLength(1);
62 // Two doors on purpose: the quiet one in the header, the primary one under the example clock.
63 expect(guest.match(/>Sign in</g)).toHaveLength(2);
64 expect(guest).toContain('<p class="start"><a class="button" href="/__forge/signin?to=%2F">Sign in</a>');
65 expect(guest).toContain("Nothing is sent without your approval");
6366 expect(guest).toContain('class="marker"');
6467 expect(guest).not.toContain("<script");
6568 expect(guest).not.toContain("Maya");
static/app.css +3
@@ -846,6 +846,9 @@ a.week-row {
846846 .welcome .card {
847847 margin-top: var(--space-5);
848848 }
849 .welcome .start {
850 margin: var(--space-4) 0 0;
851 }
849852 .welcome .marker {
850853 cursor: default;
851854 }

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs