Public: anyone can read this; the crew can change it.

small: The review page's finished screen also says how many reminders were held until tomorrow #257

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The finished screen on the review page now adds "N held until tomorrow." when any reminders were held today, and adds nothing when none were. The new tests and src/settled.test.ts pass.

Notes

shipped production is serving it deploy d2eada7

opened this

The finished screen on the review page now adds "N held until tomorrow." when any reminders were held today, and adds nothing when none were. The new tests and src/settled.test.ts pass. I could not run the other checks: tsc printed its usage text because the clone has no tsconfig, and scripts/gate.ts and scripts/design-lint.ts do not exist here, so I skipped those three. The forge's check will run on the push. I did not touch src/web/.

  • What moved: src/settled.ts gains a held count next to sent and declined, and settledLine writes it as its own sentence. The page and route are unchanged, because #251 already passes settled through.
  • Examples: "You approved 3 and declined 1 today. 2 held until tomorrow." With only holds, it reads "1 held until tomorrow."
  • How "today" is counted: holds are counted where held_on equals the agent's local day. This is the same day as the sent and declined counts, and it is read from the records, not the query string. A hold that is released or later sent is deleted, so it drops out of the count. A hold placed on a reminder that is already held counts once, under its latest hold day.
  • Tests: src/settled.test.ts covers the new wording, including the held-only case. src/review.test.ts holds a reminder through the page and checks the finished screen's count goes up by one. It also checks the count survives a done=9 query string.
  • Existing assertions changed: src/settled.test.ts already built Settled objects by hand. I added held: 0 to those so they type-check, and left their expected strings alone.
  • Not done: I did not add a held count to the "approved/declined" sentence itself, and did not change what the queue shows.

🤖 Generated with Claude Code

Closes #255

commented

The finished screen on the review page now adds "N held until tomorrow." when any reminders were held today, and adds nothing when none were. The new tests and src/settled.test.ts pass. I could not run the other checks: tsc printed its usage text because the clone has no tsconfig, and scripts/gate.ts and scripts/design-lint.ts do not exist here, so I skipped those three. The forge's check will run on the push. I did not touch src/web/.

  • What moved: src/settled.ts gains a held count next to sent and declined, and settledLine writes it as its own sentence. The page and route are unchanged, because #251 already passes settled through.
  • Examples: "You approved 3 and declined 1 today. 2 held until tomorrow." With only holds, it reads "1 held until tomorrow."
  • How "today" is counted: holds are counted where held_on equals the agent's local day. This is the same day as the sent and declined counts, and it is read from the records, not the query string. A hold that is released or later sent is deleted, so it drops out of the count. A hold placed on a reminder that is already held counts once, under its latest hold day.
  • Tests: src/settled.test.ts covers the new wording, including the held-only case. src/review.test.ts holds a reminder through the page and checks the finished screen's count goes up by one. It also checks the count survives a done=9 query string.
  • Existing assertions changed: src/settled.test.ts already built Settled objects by hand. I added held: 0 to those so they type-check, and left their expected strings alone.
  • Not done: I did not add a held count to the "approved/declined" sentence itself, and did not change what the queue shows.

🤖 Generated with Claude Code

Approved

Clean, small change. settledOn counts reminder_hold rows with held_on = the agent local day using a parameterised query; the line is escaped by the page; no contract, route or dependency change. Tests cover the wording (singular/plural, held-only, none) and the page flow, and would fail without the change. Minor note, not blocking: a re-hold of an already-held reminder can push until beyond tomorrow, so the wording is approximate in that case.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs