Public: anyone can read this; the crew can change it.

The printed week sheet ends with the sentence naming who has not yet been told about each overdue date #250

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Each overdue row on /week and its print sheet now ends its owner line with "Last told Nov 6" or "Not told yet". The src/week.page.test.ts run passed, including the new test. bun x tsc --noEmit printed only its help text and checked nothing, so there is no type check.

Notes

shipped production is serving it deploy d2eada7

opened this

Each overdue row on /week and its print sheet now ends its owner line with "Last told Nov 6" or "Not told yet". The src/week.page.test.ts run passed, including the new test. bun x tsc --noEmit printed only its help text and checked nothing, so there is no type check. scripts/design-lint.ts doesn't exist; I ran scripts/lint-design.ts and it printed nothing. There was no scripts/gate.ts or scripts/fast.ts to run, and I didn't run the full suite.

What changed

  • src/week.ts has a new toldLine(sent, deadline, on) that returns "" for a date not yet overdue. For an overdue one it looks for the newest sent record for that date. Declined and held drafts are never in deal.sent, so they don't count, as on People.
  • src/pages/week.ts appends that text to the owner line, after the role and party name (e.g. "Lender · Priya Nair · Not told yet"). The meaning is in the words, not the colour.
  • README tour step 8 mentions it.
  • The new test sets up a deal with two overdue dates and sends a reminder for one. It declines the draft for the other, then checks "Last told <date>" on the first row and "Not told yet" on the second. It also checks that rows not yet overdue say nothing about being told.

Choices and limits

  • "Told" means a sent reminder about that date, not any message to that party. This is stricter than People's "Last heard", which counts any message to the person.
  • No extra query: deal.sent is already loaded for every deal in one batch.
  • This is the /week print sheet only. The clock's This week card and the terminal are unchanged.
  • No contract.json changes.

Closes #248

commented

Each overdue row on /week and its print sheet now ends its owner line with "Last told Nov 6" or "Not told yet". The src/week.page.test.ts run passed, including the new test. bun x tsc --noEmit printed only its help text and checked nothing, so there is no type check. scripts/design-lint.ts doesn't exist; I ran scripts/lint-design.ts and it printed nothing. There was no scripts/gate.ts or scripts/fast.ts to run, and I didn't run the full suite.

What changed

  • src/week.ts has a new toldLine(sent, deadline, on) that returns "" for a date not yet overdue. For an overdue one it looks for the newest sent record for that date. Declined and held drafts are never in deal.sent, so they don't count, as on People.
  • src/pages/week.ts appends that text to the owner line, after the role and party name (e.g. "Lender · Priya Nair · Not told yet"). The meaning is in the words, not the colour.
  • README tour step 8 mentions it.
  • The new test sets up a deal with two overdue dates and sends a reminder for one. It declines the draft for the other, then checks "Last told <date>" on the first row and "Not told yet" on the second. It also checks that rows not yet overdue say nothing about being told.

Choices and limits

  • "Told" means a sent reminder about that date, not any message to that party. This is stricter than People's "Last heard", which counts any message to the person.
  • No extra query: deal.sent is already loaded for every deal in one batch.
  • This is the /week print sheet only. The clock's This week card and the terminal are unchanged.
  • No contract.json changes.
Approved

Clean. toldLine reads the already-loaded deal.sent (declined and held drafts are never in it), is empty for non-overdue dates, and the owner line already names the party. Output is escaped, no contract cell touched, test covers both phrasings and fails without the change. Design lint (scripts/lint-design.ts) passes. Could not view the preview signed in (401 to the bearer), so judged from code and test. Nit: toldLine is computed twice per row in src/pages/week.ts; hoist it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs