Public: anyone can read this; the crew can change it.
An inspection or walkthrough held at the deal's own address says "at the property" on This week, instead of repeating the address #212
On the clock's This week and the printed /week, an inspection or walkthrough held at the deal's own address now reads "Final walkthrough · 8:15 am · at the property". The new tests pass. I didn't check that they fail on main.
stopped parked by the crew deploy 3e2014f
2 earlier comments · 1 event
On the clock's This week and the printed /week, an inspection or walkthrough held at the deal's own address now reads "Final walkthrough · 8:15 am · at the property". The new tests pass. I didn't check that they fail on main. I also didn't run bun x tsc --noEmit or bun scripts/lint-design.ts, and I didn't boot a fresh instance to look at the sample deals.
- What changed:
appointmentNoteinsrc/week.tsnow takes the deal's address. When the place equals it (trimmed, case-insensitive), the place is replaced with "at the property".whereNotepassesdeal.address, and both This week callers go throughwhereNote. Any other place is shown as before, and the output is still escaped. - Left alone:
appointmentLineinsrc/appointment.tsis untouched. The deal page, client timeline, calendar file and reminder drafts therefore still show the full address. - Tests: a new test in
src/week.appointment.test.tscovers the same address, an upper-case and padded variant, and a different place on a booted/week. It also checks thatappointmentLinestill carries the full address. It uses a freshly created deal, not the seeded 1418 Alder Lane walkthrough the issue names. - Checks I couldn't run:
bun x tsc --noEmitprinted tsc's help text instead of checking types.bun scripts/lint-design.tsgave no result I could read, andscripts/fast.tsdoesn't exist in this clone. I ransrc/week.appointment.test.ts,src/week.test.ts,src/week.page.test.tsandsrc/pages, not the full suite. - Contract: no contract cells changed.
This week now says "at the property" for an inspection or walkthrough whose place is the deal's own address (#210).
I found no failure to fix. On this clone bun test passes (655 pass, 0 fail) and the type check is clean. The deploy log you sent stops mid-way through passing tests, so it shows no failing test. The branch is already pushed and git push reported "Everything up-to-date", so I made no new commit. The earlier preview failure may have been the forge restarting or the usage limit. I couldn't run scripts/gate.ts because this repository doesn't have it.
- What moved:
appointmentNoteinsrc/week.tstakes the deal's address as an optional second argument.whereNotepassesdeal.addressto it. - Matching rule: the place counts as the property when it equals the address after trimming and ignoring case. The row then reads "10:00 am · at the property" in place of repeating the address. A blank place, a different place, or a call with no address behaves as before.
- Tests:
src/week.appointment.test.tsgains cases for this. - Not done: I didn't fuzzy-match addresses (for example "St" against "Street"), and I didn't change how the deal page, calendar file or reminder draft show the place.
Parked by the crew: the check stayed red through 2 automatic tries
On the clock's This week and the printed
/week, an inspection or walkthrough held at the deal's own address now reads "Final walkthrough · 8:15 am · at the property". The new tests pass. I didn't check that they fail on main. I also didn't runbun x tsc --noEmitorbun scripts/lint-design.ts, and I didn't boot a fresh instance to look at the sample deals.appointmentNoteinsrc/week.tsnow takes the deal's address. When the place equals it (trimmed, case-insensitive), the place is replaced with "at the property".whereNotepassesdeal.address, and both This week callers go throughwhereNote. Any other place is shown as before, and the output is still escaped.appointmentLineinsrc/appointment.tsis untouched. The deal page, client timeline, calendar file and reminder drafts therefore still show the full address.src/week.appointment.test.tscovers the same address, an upper-case and padded variant, and a different place on a booted/week. It also checks thatappointmentLinestill carries the full address. It uses a freshly created deal, not the seeded 1418 Alder Lane walkthrough the issue names.bun x tsc --noEmitprinted tsc's help text instead of checking types.bun scripts/lint-design.tsgave no result I could read, andscripts/fast.tsdoesn't exist in this clone. I ransrc/week.appointment.test.ts,src/week.test.ts,src/week.page.test.tsandsrc/pages, not the full suite.Closes #210