Public: anyone can read this; the crew can change it.
A date from another year says its year, so the Closed list never shows last November's sale as "closed Sun, Nov 9" the day before Nov 9 #198
A closing date from another calendar year now says its year. On a fresh boot, 58 Larkspur Way's Closed-list entry should read "closed Sun, Nov 9, 2025". I didn't boot the app or open the clock page to check that wording.
stopped parked by the crew
3 earlier comments
A closing date from another calendar year now says its year. On a fresh boot, 58 Larkspur Way's Closed-list entry should read "closed Sun, Nov 9, 2025". I didn't boot the app or open the clock page to check that wording. The sample deal is covered only through the unit tests, and the pushed tests pass.
What changed
spoken(date, on?)insrc/dates.tstakes the agent's today as an optional second argument. When the date's year differs fromon's year it adds the year ("Sun, Nov 9, 2025"). With noon, or the same year, the output is exactly what it was.dates.tsstill never reads the clock.- Three places pass the agent's today:
- the Closed list on the clock (src/pages/clock.ts);
- the "All done · closed …" line on the deal page (src/pages/progress.ts);
- the terminal's closed list (src/terminal.ts).
- The agent's own time zone decides the year, since
onis their local today. That is what the Dec 31 to Jan 1 test pins.
Tests
src/dates.test.tspins the same-year form, the other-year form, and Dec 31 in New York against Jan 1 in UTC for the same instant.src/progress.test.tspins the "closed …" line in both forms.- Both are new tests, and the first argument-taking
spokencall can't pass on main. - The terminal, anniversary, sample, closed-book, server and status suites pass unchanged.
What I didn't do
- I didn't change the other
spokencallers: reminders, calendar drafts, the sheet, the file, "Closed on …" on the deal page and the terminal's deal view. Reminder and calendar text stays byte-for-byte. The issue named only the three places above. - I didn't run
tscorbun scripts/design-lint.ts. The repo has notsconfig.json, sotsconly prints its help text.scripts/design-lint.tsdoesn't exist in this clone. I touched no component classes.
A date from another calendar year now says its year, but I did not find the cause of the failed preview. I pushed an empty commit to re-run the deploy.
- The change:
- spoken(date, on?) in src/dates.ts adds the year when the date's year differs from the agent's today. Without on, or in the same year, the output is unchanged.
- The clock's Closed list, the deal page's "All done · closed …" line and the terminal's closed list now pass today in. 58 Larkspur Way should read "closed Sun, Nov 9, 2025".
- src/dates.test.ts pins both forms, including Dec 31 to Jan 1 across New York and UTC. src/progress.test.ts pins the progress line.
- The failed preview: this pull has no schema, migration or
/healthzchange. A fresh local boot answers/healthz200.src/upgrade.test.ts,src/health.test.tsandsrc/migrations.test.tsall pass here, so the upgrade-from-old-migrations path is fine. - What I couldn't see: the production URL answered 502 from my sandbox, so the preview environment may be broken independently of this pull. I can't read the deploy's data or its full log. If the re-run still returns 503, the 503 response body names the failed check.
- What I did not do:
tschas notsconfig.jsonto run against in this repo, andscripts/design-lint.tsdoesn't exist in this clone. I touched no component classes. The otherspokencallers (reminders, calendar drafts, sheets, file) are unchanged.
I can't find a cause in this pull, so I've pushed nothing new. The preview's /healthz still answers 503 in the deploy, but I can't reproduce it here.
- Local boots:
bun run src/server.tson a fresh data directory answers/healthz200 and/200. That holds withFORGE_APP_ENV=previewandFORGE_APP_PULL=198too, which is how the preview describes itself. - Tests: the deploy log shows the suite passing right up to the failure.
upgrade,healthandmigrationsalso pass here. - What the 503 means:
/healthzreturns 503 only when a first-paint query fails, which means the database is missing a column. It names the failed check in its body:profile,deals,datesorwaiting. A fresh database doesn't have this problem, and this pull adds no schema, migration or health change. The cause must be in the preview's existing data directory, which I can't read from the sandbox. - Production: it answered 502 from my sandbox. So the data the preview starts from may be broken independently of this pull.
A person with access should fetch the preview's /healthz body to see which check failed, and check the preview and production data directories. My diff changes only date wording in dates.ts, clock.ts, progress.ts and terminal.ts, and none of those touch the database.
I'm not pushing more empty commits, since the second one re-ran the deploy and failed the same way.
Parked by the crew: the check stayed red through 2 automatic tries
A closing date from another calendar year now says its year. On a fresh boot, 58 Larkspur Way's Closed-list entry should read "closed Sun, Nov 9, 2025". I didn't boot the app or open the clock page to check that wording. The sample deal is covered only through the unit tests, and the pushed tests pass.
What changed
spoken(date, on?)insrc/dates.tstakes the agent's today as an optional second argument. When the date's year differs fromon's year it adds the year ("Sun, Nov 9, 2025"). With noon, or the same year, the output is exactly what it was.dates.tsstill never reads the clock.- the Closed list on the clock (
src/pages/clock.ts); - the "All done · closed …" line on the deal page (src/pages/progress.ts); - the terminal's closed list (src/terminal.ts).onis their local today. That is what the Dec 31 to Jan 1 test pins.Tests
src/dates.test.tspins the same-year form, the other-year form, and Dec 31 in New York against Jan 1 in UTC for the same instant.src/progress.test.tspins the "closed …" line in both forms.spokencall can't pass on main.What I didn't do
spokencallers: reminders, calendar drafts, the sheet, the file, "Closed on …" on the deal page and the terminal's deal view. Reminder and calendar text stays byte-for-byte. The issue named only the three places above.tscorbun scripts/design-lint.ts. The repo has notsconfig.json, sotsconly prints its help text.scripts/design-lint.tsdoesn't exist in this clone. I touched no component classes.Closes #197