Public: anyone can read this; the crew can change it.
A date marked done says the day it was done and whether that was early, on time or late #132
Check · Review · Land · Live done — Landed and live in production.
A done date now reads "Done Oct 30 · 3 days early", "Done Nov 2 · on time" or "Done Nov 4 · 2 days late", on the deal's page sheet and the client timeline. The new tests and the neighbouring suites I ran pass, but I did not run the full bun test.
shipped production is serving it deploy d2eada7
A done date now reads "Done Oct 30 · 3 days early", "Done Nov 2 · on time" or "Done Nov 4 · 2 days late", on the deal's page sheet and the client timeline. The new tests and the neighbouring suites I ran pass, but I did not run the full bun test. bun x tsc --noEmit has no tsconfig.json to check in this repo, so I couldn't run it. The forge runs the full check on this push.
- Wording: a new
doneLine(due, doneOn)insrc/dates.tsbuilds the text (singular "1 day late" included). The sheet'sdueLineand the timeline row both use it. The timeline row shows it in place of the bare "Done" status word. done_on: every date on a deal view now carriesdone_on, the day it was marked done asYYYY-MM-DD, or null. It is worked out fromdone_atwithtoday(new Date(done_at)), the same helper the CSV andclosedOnuse. That avoids the midnight-UTC off-by-one. The JSON API and the MCP deal read return it automatically, and/openapi.jsondescribes it. I regeneratedcontract/openapi.json.- Reopening:
markDonealready setsdone_atto null on reopen, sodone_onclears with it. Marking done again records the new day. - Tests:
src/doneon.test.tscovers early, on time, late, one day late, and reopened then done again. It also checks the wording on the deal page sheet and the timeline page.
Not done:
- Design lint: the issue names
bun scripts/design-lint.ts, but the script here isscripts/lint-design.ts. I ran that and it printed nothing, which I'm reading as clean. - Docs: I didn't add anything to
docs/TECHNICAL.md; the only doc change is the regenerated/openapi.jsoncontract. - Behaviour: nothing else changed.
Clean. doneLine is one small helper reused by the sheet and the timeline. done_on is derived from done_at with the same today() helper the CSV uses, so reopen clears it. Output is escaped, no contract cell changed, and no new dependency. Tests cover early, on time, late, 1 day late, reopen and the page wording. The openapi contract is updated in both places.
A done date now reads "Done Oct 30 · 3 days early", "Done Nov 2 · on time" or "Done Nov 4 · 2 days late", on the deal's page sheet and the client timeline. The new tests and the neighbouring suites I ran pass, but I did not run the full
bun test.bun x tsc --noEmithas notsconfig.jsonto check in this repo, so I couldn't run it. The forge runs the full check on this push.doneLine(due, doneOn)insrc/dates.tsbuilds the text (singular "1 day late" included). The sheet'sdueLineand the timeline row both use it. The timeline row shows it in place of the bare "Done" status word.done_on: every date on a deal view now carriesdone_on, the day it was marked done asYYYY-MM-DD, or null. It is worked out fromdone_atwithtoday(new Date(done_at)), the same helper the CSV andclosedOnuse. That avoids the midnight-UTC off-by-one. The JSON API and the MCP deal read return it automatically, and/openapi.jsondescribes it. I regeneratedcontract/openapi.json.markDonealready setsdone_atto null on reopen, sodone_onclears with it. Marking done again records the new day.src/doneon.test.tscovers early, on time, late, one day late, and reopened then done again. It also checks the wording on the deal page sheet and the timeline page.Not done:
bun scripts/design-lint.ts, but the script here isscripts/lint-design.ts. I ran that and it printed nothing, which I'm reading as clean.docs/TECHNICAL.md; the only doc change is the regenerated/openapi.jsoncontract.Closes #115