A refresh does not end your match: resume the one you were playing #117

Pushed. Here's the summary:

A match now survives a refresh, a crash or a closed tab.

What changed:

• src/client/saved.ts (new): a snapshot of the round, score, loss streak, which side you're on, the world seed, your name and every player's money/gear/kills. snapshot(world, matchId) builds it; parseSaved is the boundary — an unknown weapon id, money out of range, the wrong player count, a hostile or oversized blob, or a matchId not shaped like the server's all become null. restore(snapshot, difficulty) turns a valid one back into a World.
• world.ts: createWorld takes an optional save: MatchSave applied before startRound; startRound gained a skipBotBuy flag so a restored round's bots don't re-shop the money they already spent for it.
• main.ts: writes a snapshot once at the start of every freeze time (fresh or resumed), clears it when the match ends or Leave match is used, and offers Resume match — round 9, 5–3 in the menu, discarding any old snapshot only once a new match actually starts. A resumed match keeps its original matchId, so the leaderboard row continues — including flipping an age-abandoned row back to live — instead of duplicating.
• game.ts: two hidden elements in the menu for the resume button and the discard warning.
• README: documents what survives a refresh and what doesn't.

Left out, per the issue: mid-round position, health and the bomb; resuming across devices; and resuming under rules the code no longer ships (the snapshot names the rule set, not its numbers).

To try it: start a match, play a round or two, then reload the page — the menu now shows Resume instead of only Play.

bun test is green (445 tests, including new round-trip, hostile-input and loss-bonus-after-restore tests in saved.test.ts and world.test.ts).

Closes #71

Merged main into this branch and resolved the one conflict in src/client/world.test.ts, where both branches had added tests in the same spot: main's radio tests and this branch's save/restore tests are now both kept, one after the other. Everything else (main.ts, game.ts, README.md) auto-merged cleanly — the new radio panel's show/hide calls slot into enterMatch/toMenu/the match-over block right alongside the resume logic, and world.ts's new radio field is correctly left out of the snapshot (it's mid-round state, cleared every round already). bun test is green at 464 tests, and the branch is pushed.

Review submitted on pull #117 as one anchored review (src/pages/game.ts:222, changes requested). The clone is untouched and clean; nothing was pushed.

What I found, in the order I put it to the builder:

1. Empty blue button on the first paint for everyone — #resume-row is a .row, and .row { display:flex } overrides the UA's [hidden] { display:none }, so the resume row is never hidden. Both screenshots show the blank 44×44 primary button in the menu. Fix: #resume-row[hidden] { display:none; }, matching .overlay[hidden] and #touch[hidden].
2. bun run check goes red on merge — the branch predates the tsc --noEmit from #115; merged onto main it fails with TS2352 in saved.test.ts:21 (the globalThis → FakeStorage cast). bun test alone is 475 pass / 0 fail.
3. Second-half resume shuffles the roster — after the half-time swap the saved playerTeam makes createWorld rebuild the sides mirrored, so bots 1–4 and 6–9 come back with the opposing side's money, pistol and defuse kit (reproduced: Ts holding USPs and kits). Snapshot needs each player's team.
4. Resumed matches can't post — restore starts world.time at 0 while postResult sends it as seconds, and the server refuses seconds < rounds × 10; verified locally, {rounds:9, seconds:40} → 422, seconds:95 → 200. So the abandoned row does not flip back to live as the README claims.

Security held up: parseSaved is a genuine boundary, and saveMatch already refuses a match id owned by another identity, so a hand-edited snapshot can't touch someone else's row. The preview itself answers 404 on every path — the deployment appears to be down, which I noted in the review.

Pushed. All four review issues are fixed and bun run check is green:

1. Empty blue button — added #resume-row[hidden] { display:none; } next to the other [hidden] overrides, since .row's own display:flex was beating the UA default at equal specificity.
2. bun run check red on merge — rebased onto current main (which brought in #115's tsc --noEmit) and fixed the one strict-mode error: FakeStorage now implements Storage instead of being force-cast.
3. Second-half resume shuffled the roster — each player's own team is now part of the snapshot (half time flips it in place; it can't be re-derived from playerTeam and a fixed construction order once a match has swapped). parseSaved now also checks the roster is five-a-side and that me agrees with playerTeam. Added a test that runs a match through its own half-time swap and confirms every player restores to the side it actually flipped to, not a mirrored one.
4. Resumed matches couldn't post — the snapshot now carries world.time (as seconds, range-checked the same way result.ts bounds a fresh result), and restore seeds the clock from it instead of starting at zero, so postResult's seconds clears the server's seconds ≥ rounds × 10 check and the row comes back to live.

Also addressed both non-blocking notes in the README: a pocketed-but-unused grenade is dropped by the snapshot (money not refunded — undocumented before, now called out), and resuming after signing in over what started as a guest session posts under the new identity, so the guest row is left behind rather than continued (also now documented). I didn't change server-side behavior for that second one — it's the same "a match id belongs to the identity that first sent it" rule already protecting everyone else's rows, so refusing it is correct; only the gap in the write-up needed fixing.

I could not re-check the preview this round (no way to observe the forge's deployment from here), but the fix that caused the 404 wasn't something in this diff as far as I can tell — worth a look on the next pass if it's still down.

Merged main into this branch. The one conflict was in src/client/main.ts's import block, where both sides had added a new import group at the same spot — this branch's saved.ts (resume) imports and main's new crosshair.ts/parseCrosshair (from #121, the crosshair settings pull). Kept both. Everything else merged cleanly. bun run check (typecheck + tests) is green at 515 tests, and the branch is pushed.

Approved pull #117 with one anchored review at src/pages/game.ts:155. Nothing pushed; the clone is untouched.

All four findings from the first round are fixed, each verified at head 22f5762 merged onto today's main:

• bun run check green merged (tsc clean, 515 pass / 0 fail); FakeStorage implements Storage removes the old TS2352 without an unknown cast.
• The empty blue button is gone — #resume-row[hidden] { display:none; } is in the served CSS and both screenshots show the menu clean.
• Half-time resume is correct: a real SHORT match to round 6, snapshot → parse → restore puts all ten ids back on the side they flipped to with their own money, pistol and kit, and round 7 does not re-swap. parseSaved enforces five-a-side and players[0].team === playerTeam.
• The clock is carried: the resumed post (rounds:5, seconds:548) → 200 and the finishing post → 200, leaving one row reading finished — the pair that was 422 before.

Mutation-checked the two key tests (removing p.team = saved.team fails three, removing world.time = save.seconds fails two). Security floor intact, no server surface added, no new dependency. The preview is 404, but so is production and #118's preview, so the hosting is down rather than the branch — I ran the merged tree locally instead and said so in the review.

This review is an approval — no changes requested. @sentinel verified all four prior findings are fixed (green bun run check, the empty button gone, the half-time roster fix, and the clock/leaderboard fix), confirmed the tests are load-bearing via mutation checks, and confirmed the security floor is intact. The one thing flagged — the preview answering 404 — was already attributed to the platform's hosting being down (production and another PR's preview are both 404 too), not to this branch, and explicitly called out as not blocking.

There's nothing to address and nothing to push: the branch (22f5762) is already up to date with origin, clean, and matches what was reviewed and approved.

Merged main into this branch. The one conflict was in src/client/main.ts's import lines: main's #124 moved the earshot/hearing logic out of main.ts (into the new earshot.ts) and dropped its now-unused dist import from math.ts, while this branch still needs other from match.ts for the resume button's "round 9, 5–3" line. Kept clamp (still used) and other, dropped dist (no longer referenced anywhere in main.ts).

bun run check is green: typecheck clean, 530 tests pass across 55 files, including main's new main.test.ts (which checks every DOM id main.ts reaches for exists in game.ts — our resume-row/resume-hint/resume-match ids all still line up).

Approved pull #117 with one anchored review at src/client/saved.ts:210. No code written, nothing pushed, clone clean.

Verified at head f84c32a merged onto today's main (tree eac62aa):

• The pull's own files are byte-identical to the head I approved last round; the only change is main merged in (earshot.ts, main.test.ts, tree.test.ts, .scout-tmp removal).
• bun run check green merged: tsc clean, 530 pass / 0 fail — including the new main.test.ts id contract from #127, which now binds resume-row, resume-hint and resume-match to the markup.
• Both screenshots show a clean menu; #resume-row[hidden] { display:none; } is in the served CSS.
• Second-half resume re-probed: all ten players return on the side they flipped to with their own money, pistol and kit; clock carried; no spurious re-swap at round 7.
• Resumed-match post path re-tested against the booted merged app: 200 for the resumed post and 200 for the finishing post under the same id, row reads finished; / answers in 10 ms with the security headers intact.

The deployed preview is 404, but so is production, so the hosting is down rather than the branch — noted in the review rather than held against it.

Parked by the crew: the check failed and the decider saw no point in another try