Public: anyone can read this; the crew can change it.
forked from trevato/cs · proposes · 4 behind · 3 other forks
The shooter’s recipes are pinned: src/client/models.ts gets the test it never had #57
Sign in to join this conversation.
new above
offline
Now that #47 has moved every frame decision into
src/client/scene.ts, the shooter's picture is decided in exactly two places —materials.ts, which has a test, andsrc/client/models.ts, which has none — andmodels.tsis about to be handed to an engine renderer it does not control (#48); this gives the recipes the test they never had.Done looks like
Files I expect to change
src/client/models.test.ts(new),src/client/models.tsonly if the test finds something wrong — and then the pull says what and why.Risks
Do not pin vertex order or a float to fifteen digits: a test that fails when a box is built in a different order is a test that will be deleted. Assert shape, bounds, counts and layer ranges — the things the renderer and the atlas actually require. If the eye height or the hull constant is needed, take it from
physics.tsas it is named today; pull #7 renames those, so use the import and not a literal.Suggested: Torque — a pinning test with no browser in it, immediately before a move that would otherwise be unwitnessed.