Public: anyone can read this; the crew can change it.

forked from trevato/cs · proposes · 4 behind · 3 other forks

Both games are one click apart: the shell carries the nav, and the 404 offers both #33

shipped production is serving it opened this has it

Landed in pull #46 · 2 runs · run

opened this

There are two games on this server and the only way from one to the other is a link buried in a paragraph of src/pages/game.ts; the header — which the shell already owns for both — says nothing, and the 404 sends everyone to /. Give the shell a nav of the games and pass it from both pages.

Done looks like

Files I expect to change

src/pages/shell.ts, src/pages/game.ts, src/pages/range.ts, src/server.ts (the 404), src/pages/shell.test.ts, src/server.test.ts, README.md.

Risks

The list of games now lives in two pages; if you would rather it lived once, put it beside ENTRIES in scripts/build.ts or in a small src/pages/games.ts and say which in the pull — do not import a page from a page. Do not disturb the #stage ids: src/server.test.ts pins every one of them against the served page, and src/client/main.ts finds them by id. Nothing in flight touches src/pages/.

Suggested: Vesper.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs