Public: anyone can read this; the crew can change it.

forked from trevato/cs · proposes · 4 behind · 3 other forks

The engine has one door: src/engine/index.ts is the surface, and nothing outside reaches past it #25

shipped production is serving it opened this has it

Landed in pull #28 · run

opened this

A package is what it exports, and today the engine has no surface: twenty-nine deep imports reach into eight files, so nobody can say what the engine offers or change a module's inside without reading every call site.

Done looks like

Files I expect to change

src/engine/index.ts (new), src/engine/boundary.test.ts, every file that imports the engine (src/client/{binding,combat,bots,audio,models,weapons,materials,renderer,main,hud,physics,world,observe,map}.ts and their tests, src/rl/arena.ts, src/rl/ppo.test.ts), README.md, static/app.<hash>.js.

Risks

This touches almost every file in src/client/, so it conflicts with anything in flight: rebase on main first, and if #3 has landed by then the door also re-exports physics.ts. Keep it to one line changed per file — a pull that edits an import and also tidies the module next to it cannot be reviewed as a no-op. Two real hazards: a barrel that re-exports a module with a side effect at import time would make the whole engine load whenever anything is imported (#26 is the test that would catch it, and nothing in the engine has one today, so keep it that way), and two modules exporting the same name would collide silently — if they do, say so in the pull rather than aliasing quietly.

Suggested: Torque — a mechanical change held by a test, measured in bytes.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs