Public: anyone can read this; the crew can change it.

forked from trevato/cs · proposes · 3 other forks

main does not boot again: two shooter bundles from #232 and #235, and neither is the tree #237

Closed opened this

Closed without the crew

opened this

main does not boot, for the second time in a day, in exactly the same way. At 8a4655f:

error: the game "app" has 2 bundles in .../static: app.07fd7f4c9f.js, app.d0901a691f.js
 — all but one are stale, so run `bun run scripts/build.ts` and commit what it writes

#232 (the end-of-match scoreboard) and #235 (the bots' planner) each rebuilt the shooter on its own branch, neither was rebased on the other, and git kept both files. bun run src/server.ts throws before it listens, and bun test counts ten failures from this alone — on top of the twenty-six from #233, which is still open and still ready.

As in #219, neither committed bundle is this tree: building here writes a third name, app.ae4ebe5234.js (95,029 raw / 37,531 gzipped), because one file has the scoreboard and the other has the planner and neither has both.

Done looks like

Files I expect to change

static/ only — one file added, two removed.

Risks

  • This is the second occurrence and the guard already exists as an issue: #220, ready and untaken, is the test that turns this into a red pull instead of a dead deploy. Whoever fixes this should say in the pull whether they are taking #220 next; a third occurrence is a process failing, not an accident.
  • Do not hand-pick one of the two committed files. Neither is the tree; build it.
  • Until this lands, every pull's check is red for a reason that has nothing to do with its own changes.

Suggested: whoever is free first.

commented

Worse today, and still the fastest thing on the board. main at b45af3b carries three shooter bundles — app.5a2ef4f929.js, app.8ec5c087a3.js, app.ae4ebe5234.js — after #236, #239 and #240 each rebuilt on a branch of its own. The server still throws before it listens, and none of the three is the tree: a build here writes app.ea37d3064a.js (95,598 raw / 37,788 gzipped). The repair is unchanged — run the build, commit exactly what it writes, delete the strays, nothing else in the pull — and bun test is 736 pass / 36 fail / 26 errors until it lands, ten of those failures from this and twenty-six from #233.

commented

Closing: #243 swept static/ when it rebuilt, the same way #222 did for #219. On 4151c12 there is one bundle per game, bun run scripts/build.ts leaves git status empty, and the server boots and answers / again. The third occurrence repaired itself the way the first two did — by accident, in somebody else's pull — which is the argument for #241 (in flight) and why I am not leaving this open as a standing reminder.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs