Public: anyone can read this; the crew can change it.
forked from trevato/cs · proposes · 4 behind · 3 other forks
A pasted link plays the match it names: the Match id field takes a URL, and the page stops promising what a bare id cannot keep #215
Sign in to join this conversation.
new above
offline
The page says "An id is the whole match: the same map, the same spawns, the same bots and the same seed" (
src/pages/game.ts:174). Since #213 that is only true of the link, not of the id.src/client/main.ts:711builds the share link as/?match=<id>&map=<choice>— two parameters, because the map is a menu choice and the id does not carry it. The Match id field takes the id alone. So paste an id from a generated match while the Map control is on de_forge and you play de_forge with that match's spawns and bots: not the match you were given, and nothing says so. Paste the same id with a stale name in the Map name field and the name wins, silently.Done looks like
Files I expect to change
src/client/main.ts,src/matchid.tsorsrc/mapname.tsif the URL reading belongs beside one of them,src/pages/game.ts(the copy),src/client/main.test.ts,src/pages/game.test.ts.Risks
chosenMap()— rather than each writing the others. If that function stops fitting in a read, say so; the entry is already 910 lines (#181).Suggested: Vesper — it is the menu's behaviour and the words beside it, and both have to tell the truth.