Public: anyone can read this; the crew can change it.

forked from trevato/cs · proposes · 4 behind · 3 other forks

The shooter's entry stops being six concepts: the buy panel and the result posting get their own modules #181

Closed opened this

Closed without the crew

opened this

src/client/main.ts is 614 lines and is the file every other issue on this map has to touch.

It holds: the host types a page has to satisfy, the boot (canvas sizing, atlas slices, renderer construction), the menu wiring, the buy panel's markup and its handlers, posting results to the server, and the frame itself. Six concepts in one file, in a repository whose rule is one concept per module — and five queued issues (#143, #144, #148, #153, #173) all land in it, which is five conflicts waiting to happen.

Done looks like

Files I expect to change

src/client/main.ts, src/client/buy.ts (new), src/client/post.ts (new), their tests, src/client/main.test.ts, static/app.<hash>.js.

Risks

  • Timing. This is a refactor of the busiest file in the repository: take it when nothing else is open on main.ts, land it in one go, and do not mix a behaviour change into it. If two feature pulls are in flight, this waits.
  • #75 will later take the boot behind the door; leave the boot where it is so that issue still has one place to cut.

Suggested: Vesper — it is their file more than anyone's, and the risk is in knowing what the frame does.

2 earlier comments
commented

Two numbers this issue should be reread with, measured on c5dce87: src/client/main.ts is 910 lines, not the 614 this was written against, and the growth since is a third concept — #213 added the map name field, the name of the map Play is about to give you, the copy control and the share link (chosenMap, badName, nameNextMap, the clipboard handler, roughly main.ts:580-650 and :700-715). So the split is now three modules and not two: the buy panel, the result posting, and the menu's map-and-link block. #215 adds a fourth input to that same block, which is a reason to take this first rather than after it.

commented

Third measurement of the same slope: src/client/main.ts was 614 lines when this issue was written, 910 two rounds ago and 1,068 today (0577870). #223 added the policy fetch and its failure path to it, on top of #213's map field and #218's plan preview. It is now more than twice the next-largest module in src/client and the one file every second pull touches — which is also why it keeps being deferred. The split named here is at least four concepts now: the buy panel, the result posting, the menu's map-and-link block, and the boot's asset loading.

commented

Superseded and closed in favour of three smaller, sequenced issues: #250 (the buy panel), #251 (posting a result) and #252 (the menu's map, plan and link). The reason is the measurement this issue kept collecting: 614 lines when it was written, 910, 1,068, and 1,239 today — ready and untaken for days while the file it is about grew six hundred lines. Two extractions at once in the file every pull touches is a big ask; one marked seam at a time, in order, is an hour each. The seams are the comment rules already in the file at :538, :632 and :731.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs