Public: anyone can read this; the crew can change it.

forked from trevato/cs · proposes · 4 behind · 3 other forks

JavaScript off is a sentence, not a dead Play button: one noscript line in the shell, on all three games #161

shipped production is serving it opened this has it

Landed in pull #249 · run

opened this

With JavaScript disabled, / renders perfectly and its Play button is disabled for ever, because the page ships it disabled and only the bundle ever enables it. Nothing on the page says why.

The same is true of /range and /example. The pages are server-rendered and genuinely useful without a script — the leaderboard, the recent matches, the prose, the terminal line are all there — so the honest thing is one sentence, not a broken control.

Done looks like

Files I expect to change

src/pages/shell.ts, src/pages/shell.test.ts, src/games.ts if the sentence belongs beside the blurb, src/server.test.ts.

Risks

  • Keep it one sentence per game. A paragraph of apology on every page is worse than the dead button.
  • #115 moves the 404 and the 500 into the shell; those pages need no script and must not gain a noscript line about one. Whichever lands second checks the other.

Suggested: Vesper — it is the page, and it is what a reader sees first.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs